> -        print open(i).read()
> +        sys.stdout.write(open(i).read()+"\n")

This will leak fds, which python wonderfully loudly complains about in Python 
3. It's also a good opportunity to replace any pairs of open() and close() with 
a with statement. If an open() and close() isn't wrapped in a with or 
try/finally, I would argue that is a bug.
-- 
https://code.launchpad.net/~dmitrij.ledkov/apparmor/py3/+merge/109682
Your team AppArmor Developers is requested to review the proposed merge of 
lp:~dmitrij.ledkov/apparmor/py3 into lp:apparmor.

-- 
AppArmor mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor

Reply via email to