On 08/07/2012 09:58 AM, Seth Arnold wrote: > The patch reads well, though the --help needs to indicate that the flag only > works if --write-cache is given _and_the features don't match. > > I would much rather --clear-cache be a debugging tool for sysadmin use that > immediately and directly clears the cache, and introduce a different name for > this option. I propose --clear-cache-if-needed. > I am okay with --clear-cache-if-needed but its going to be used as more than a debugging tool suse will be using it in conjunction with --write-cache to clear the cache out when the feature set changes.
> I think the test (yay tests) would read better with this changed to use cmp > -s: > > +echo -n "monkey" | diff -q $basedir/cache/$profile - | grep -q 'differ' || { > echo "FAIL"; exit 1; } > > +echo -n "monkey" | cmp -s $basedir/cache/$profile || { echo "FAIL"; exit 1; } > sure -- AppArmor mailing list AppArmor@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor