On 08/13/2012 12:16 PM, Steve Beattie wrote:
> On Wed, Aug 08, 2012 at 08:00:04PM -0700, John Johansen wrote:
>> Rework and update the apparmor_parser man page. It reworks some of the
>> text but mostly just reorganizes the commands and options into logical
>> grouping to make it easier to sort out how the various commands and
>> options work.
>>
>> Signed-off-by: John Johansen <[email protected]>
> 
> A nice improvement. A couple of comments inline follow.
> 
>> === modified file 'parser/apparmor_parser.pod'
>> --- parser/apparmor_parser.pod       2012-02-24 12:21:59 +0000
>> +++ parser/apparmor_parser.pod       2012-08-09 02:55:02 +0000

<< snip >>


>> +=item -p, --preprocess
>> +
>> +Dump the input profile to stdout out applying preprocessing flattening
>> +includes into the output profile.
> 
> This reads awkwardly. Perhaps:
> 
>   Apply preprocessing to the input profile by flattening includes
>   into the output profile and dump to stdout.
> 
> (Preprocessing doesn't do anything besides flatten includes, IIRC?)
> 
No it doesn't atm


<< snip >>

>>  
>> +=item -B, --binary
>> +
>> +Load a binary (cached) profile, as produced with the -S or -o options
>> +(implies -K and -T).
> 
> Might want to reiterate that the binary profile is read from stdin. Or
> am I confused as to where it takes the binary blob from?
> 
okay


-- 
AppArmor mailing list
[email protected]
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor

Reply via email to