Hello,
Am Mittwoch, 2. Januar 2013 schrieb John Johansen:
> On 01/02/2013 02:37 PM, Steve Beattie wrote:
> > === modified file 'profiles/Makefile'
> > --- profiles/Makefile 2013-01-02 22:33:12 +0000
> > +++ profiles/Makefile 2013-01-02 22:35:22 +0000
[...]
> > -check: check-parser check-logprof
> > +check: check-parser
> I am fine with this
>
> Acked-by: John Johansen <john.johan...@canonical.com>
No objections, but adding a comment like
# Note: check-logprof is not called by make check because logprof
# doesn't support some new profile syntax
would be useful IMHO to
a) clarify that it's intentional / not a Makefile bug
b) have a hint that it needs to be re-added when logprof is updated
With such a comment added (I don't care about the exact wording),
Acked-by: Christian Boltz <appar...@cboltz.de>
Regards,
Christian Boltz
--
Ich kriege Druck von beiden Seiten. Den technisch Bewanderten ist
man immer der "Agenturheini, kein Ahnung, Hauptsache bunt" - und für
die Kreativen ist man immer "Der Langweiler, der am liebsten alles
SchwarzWeissTimesNew runterrasseln" würde. Beides macht das Web nicht
besser. [Ratti in suse-linux]
--
AppArmor mailing list
AppArmor@lists.ubuntu.com
Modify settings or unsubscribe at:
https://lists.ubuntu.com/mailman/listinfo/apparmor
