The final test in mount.sh, TEST A5, incorrectly specified that the
test should pass. The test should fail, due to mount mediation.

Signed-off-by: Tyler Hicks <tyhi...@canonical.com>
---
 tests/regression/apparmor/mount.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/regression/apparmor/mount.sh 
b/tests/regression/apparmor/mount.sh
index e9429cb..f991877 100755
--- a/tests/regression/apparmor/mount.sh
+++ b/tests/regression/apparmor/mount.sh
@@ -77,9 +77,9 @@ runchecktest "MOUNT (confined)" fail mount ${loop_device} 
${mount_point}
 genprofile
 runchecktest "UMOUNT (confined)" fail umount ${loop_device} ${mount_point}
 
-# TEST A5.  confine UMOUNT - cap sys_admin allows unmount
+# TEST A5.  confine UMOUNT - cap sys_admin is not sufficient to unmount
 genprofile capability:sys_admin
-runchecktest "UMOUNT (confined)" pass umount ${loop_device} ${mount_point}
+runchecktest "UMOUNT (confined)" fail umount ${loop_device} ${mount_point}
 
 # cleanup, umount file
 /bin/umount ${loop_device} > /dev/null 2> /dev/null  || /sbin/losetup -d 
${loop_device} > /dev/null 2> /dev/null
-- 
1.9.1


-- 
AppArmor mailing list
AppArmor@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor

Reply via email to