On 08/20/2014 01:02 AM, Steve Beattie wrote: > On Fri, Aug 15, 2014 at 12:20:42PM -0700, [email protected] wrote: >> We need to rework permission type mapping to nodesets, which means we >> need to move the nodeset computations earlier in the dfa creation >> processes, instead of a post step of follow(), so move the nodeset >> into expr-tree >> >> Signed-off-by: John Johansen <[email protected]> > I think this is okay, Acked-by: Steve Beattie <[email protected]> > > A stylistic question for you: where do you draw the line between > implementing in a header file and implementing in a .cc file? > Wait, there is a line?
Seriously its just not something I think about a lot. Generally if the change is large or I am making it depend on some static fns in the .cc, other wise its what ever was convenient at the time. Feel free to call me on it, and request changes -- AppArmor mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
