On Thu, Nov 27, 2014 at 12:29:12AM +0100, Christian Boltz wrote: > Hello, > > this patch adds tests for sub_str_to_mode() and split_log_mode() in > aamode.py. These are the functions that Peter's patch changes. > > Those tests were written with the "old" functions in place (without > Peter's patch) to make sure they match the current behaviour. > > Spoiler: Peter's aamode.py patch passes all tests ;-)
can you add def test_split_log_mode_6(self): self.assertEqual(split_log_mode('rw::rw'), ('rw', 'rw')) to AamodeTest_split_log_mode, and def test_sub_str_to_mode_dupes(self): self.assertEqual(sub_str_to_mode('rwrwrw'), {'r', 'w'}) to AamodeTest_sub_str_to_mode, please? Acked-by: Steve Beattie <st...@nxnw.org> (I do wonder what happens with split_log_mode('r::w::r') ) Thanks. -- Steve Beattie <sbeat...@ubuntu.com> http://NxNW.org/~steve/
signature.asc
Description: Digital signature
-- AppArmor mailing list AppArmor@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor