On 2015-12-15 17:37:35, Tyler Hicks wrote: > On 2015-12-02 22:00:32, Christian Boltz wrote: > > Hello, > > > > Am Dienstag, 1. Dezember 2015 schrieb Christian Boltz: > > > Am Montag, 30. November 2015 schrieb Tyler Hicks: > > > > A common usage of aa-easyprof is to pipe its stdout to a file > > > > representing an AppArmor profile. Errors must go to stderr. > > > > > > > > https://launchpad.net/bugs/1521400 > > > > > > > > Signed-off-by: Tyler Hicks <tyhi...@canonical.com> > > > > --- > > > > > > > > utils/aa-easyprof | 5 ++++- > > > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/utils/aa-easyprof b/utils/aa-easyprof > > > > index 93861ae..8e9db71 100755 > > > > --- a/utils/aa-easyprof > > > > +++ b/utils/aa-easyprof > > > > > > > > @@ -53,7 +53,10 @@ if __name__ == "__main__": > > > > error("Could not read '%s': %s (%d)\n" % (opt.manifest, > > > > > > > > os.strerror(e.errno), e.errno)) - profiles = > > > > apparmor.easyprof.parse_manifest(manifest, opt) + try: > > > > + profiles = apparmor.easyprof.parse_manifest(manifest, > > > > opt) > > > > + except AppArmorException as e: > > > > + error(e.value) > > > > > > > > else: # fake up a tuple list when processing command line args > > > > > > > > profiles.append( (binary, opt) ) > > > > > > NAK. > > > > > > aa-easyprof is using apparmor.fail for exception handling, so it > > > doesn't make sense to fix this only for aa-easyprof. We should fix > > > this in apparmor.fail so that everybody benefits ;-) > > I was simply making this call site apparmor.easyprof.* call sites which > catch AppArmorExceptions and print the error to stderr.
Bah. I meant, "I was simply making this apparmor.easyprof.* call site match the other apparmor.easyprof.* call sites which catch AppArmorExceptions and print the error to stderr." Tyler
signature.asc
Description: Digital signature
-- AppArmor mailing list AppArmor@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor