On Mon, Dec 21, 2015 at 12:11:11AM +0100, Christian Boltz wrote: > Hello, > > Am Sonntag, 20. Dezember 2015 schrieb Christian Boltz: > > we need to check a rule part if it is *Rule.ALL or a string at various > > places. Therefore split off the checks in PtraceRule's and > > SignalRule's __init__() to the new _aare_or_alll() function in > > BaseRule. > > > > This also makes the *Rule __init__() much more readable because we now > > have one line to set self.foo and self.all_foo instead of 10 lines of > > nested if conditions. > > I missed that we need the is_path flag, so here's v2: > > > [ 39-split-off-aare_or_all.diff ]
I'm not crazy about the return tuple, but Acked-by: Steve Beattie <st...@nxnw.org>. Thanks. -- Steve Beattie <sbeat...@ubuntu.com> http://NxNW.org/~steve/
signature.asc
Description: Digital signature
-- AppArmor mailing list AppArmor@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor