On Mon, Jan 25, 2016 at 11:47:09AM -0800, Steve Beattie wrote: > This is an unchanged resend of the patch from this thread: > https://lists.ubuntu.com/archives/apparmor/2015-August/008494.html > > The first entry in the grouping_count array is never initialized to 0; > subsequent depths are. This patch fixes the issue. > > [parser-fix_uninitialized_grouping_value.patch] > > Signed-off-by: Steve Beattie <[email protected]>
Acked-by: Seth Arnold <[email protected]> (slighly suggested to memset the whole thing to zero, or maybe assign the whole thing to zero: int grouping_count[MAX_ALT_DEPTH] = {0}; -- but this alone is better than current. :) Thanks > --- > parser/parser_regex.c | 1 + > 1 file changed, 1 insertion(+) > > Index: b/parser/parser_regex.c > =================================================================== > --- a/parser/parser_regex.c > +++ b/parser/parser_regex.c > @@ -122,6 +122,7 @@ pattern_t convert_aaregex_to_pcre(const > int ingrouping = 0; /* flag to indicate {} context */ > int incharclass = 0; /* flag to indicate [ ] context */ > int grouping_count[MAX_ALT_DEPTH]; > + grouping_count[ingrouping] = 0; > > error = e_no_error; > ptype = ePatternBasic; /* assume no regex */ >
signature.asc
Description: Digital signature
-- AppArmor mailing list [email protected] Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
