On Mon, Feb 01, 2016 at 07:35:07PM +0100, Christian Boltz wrote: > --- utils/test/test-aa.py 2016-01-26 22:22:14.660008000 +0100 > +++ utils/test/test-aa.py 2016-02-01 18:53:10.085684909 +0100 > @@ -14,8 +14,9 @@ > from common_test import read_file, write_file > > import os > > -from apparmor.aa import (check_for_apparmor, > get_interpreter_and_abstraction, create_new_profile, > +import apparmor.aa as aa # needed to set global vars in some tests > +from apparmor.aa import (check_for_apparmor, get_output, get_reqs, > get_interpreter_and_abstraction, create_new_profile,
Most of this looked good but I'm a bit worried about the global variables. Could they be referenced via apparmor.aa.<whatever> instead? I think that'd lead to better comprehension two years from now.. Thanks
signature.asc
Description: Digital signature
-- AppArmor mailing list AppArmor@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
