On 2016-02-11 13:20:58, Steve Beattie wrote: > On Thu, Feb 11, 2016 at 02:54:53PM -0600, Tyler Hicks wrote: > > This test causes `make check` to fail but it is known bug so mark it as > > a TODO test. > > > > Signed-off-by: Tyler Hicks <tyhi...@canonical.com> > > --- > > parser/tst/simple_tests/file/ok_bare_1.sd | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/parser/tst/simple_tests/file/ok_bare_1.sd > > b/parser/tst/simple_tests/file/ok_bare_1.sd > > index 5097f38..b8d6d06 100644 > > --- a/parser/tst/simple_tests/file/ok_bare_1.sd > > +++ b/parser/tst/simple_tests/file/ok_bare_1.sd > > @@ -1,6 +1,7 @@ > > # > > #=Description bare file rule > > -#=EXRESULT PASS > > +#=EXRESULT FAIL > > +#=TODO https://launchpad.net/bugs/1215637 > > # > > Please keep the expected result as-is (i.e. '#=EXRESULT PASS'); > otherwise, perl's prove script will tell you that the todo test has > passed[0]. Marking the test as todo just says to not fail the overall > testrun based on the failure of that test (because fixing it is still > on the todo list).
Bah... that's what I meant to do but screwed up when trying to quickly send this patch out. Thanks for catching that. > With the expected result set correctly, > Acked-by: Steve Beattie <st...@nxnw.org>. Thanks! I'll run another `make check` before committing the updated test. Tyler > Thanks. > > [0] In fact, we have some currently marked todo tests that pass their > tests: > > TODO passed: 71337, 71348-71349, 71383, 71466 > > which are: > > ok 71337 - TODO: ./simple_tests//vars/vars_profile_name_14.sd: > reference variables in rules that also have alternations # TODO Unfixed > testcase. > ok 71348 - TODO: ./simple_tests//vars/vars_profile_name_25.sd: > reference variables is null # TODO Unfixed testcase. > ok 71349 - TODO: ./simple_tests//vars/vars_profile_name_26.sd: > reference variables is null # TODO Unfixed testcase. > ok 71383 - TODO: ./simple_tests//xtrans/minimize-x-conflict.sd: test > for conflict resolution in minimization phase of dfa gen # TODO Unfixed > testcase. > ok 71466 - TODO: ./simple_tests//xtrans/x-conflict.sd: test for > conflict resolution in minimization phase of dfa gen # TODO Unfixed testcase. > > (They ought to be confirmed to have been addressed before removing > the TODO annotation.) > > -- > Steve Beattie > <sbeat...@ubuntu.com> > http://NxNW.org/~steve/ > -- > AppArmor mailing list > AppArmor@lists.ubuntu.com > Modify settings or unsubscribe at: > https://lists.ubuntu.com/mailman/listinfo/apparmor
signature.asc
Description: Digital signature
-- AppArmor mailing list AppArmor@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
