On 02/08/2017 06:23 PM, Seth Arnold wrote:
> On Wed, Feb 08, 2017 at 10:01:45PM +0000, Tyler Hicks wrote:
>> if USE_SYSTEM is not set, the utils make check target will instruct
>> test-aa-easyprof.py to provide the path of the in-tree parser executable
>> to aa-easyprof.
>>
>> If USE_SYSTEM is set, the default parser path (/sbin/apparmor_parser or
>> the result of `which apparmor_parser`) is used.
>>
>> The test-aa-easyprof.py script receives the parser path by checking the
>> __AA_PARSER environment variable. This environment variable is strictly
>> used by the test script and not any user-facing code so two leading
>> underscores were used.
>>
>> Signed-off-by: Tyler Hicks <tyhi...@canonical.com>
>> Cc: Christian Boltz <appar...@cboltz.de>
>> Cc: Jamie Strandboge <ja...@ubuntu.com>
>> ---
>
> This appears to suffer a similar problem:
>
>> + # Check __AA_PARSER, which may be set by the Makefile, to see if
>> + # we should use a non-default apparmor_parser path to verify
>> + # policy
>> + parser = os.getenv('__AA_PARSER')
>> + if parser:
>> + self.full_args.append('--parser=%s' % parser)
>> +I feel like this one behaves as intended. If __AA_PARSER is an empty string, the "if parser:" conditional is tests out to be false and self.full_args remains unchanged. Tyler
signature.asc
Description: OpenPGP digital signature
-- AppArmor mailing list AppArmor@lists.ubuntu.com Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/apparmor
