On Sun, Aug 27, 2017 at 05:53:05PM +0200, Christian Boltz wrote:
> -    log_reader = apparmor.logparser.ReadLog(log_pid, logfile, 
> existing_profiles, profile_dir, log)
> +    log_reader = apparmor.logparser.ReadLog(log_pid, logfile, 
> existing_profiles, profile_dir, [])
>      log = log_reader.read_log(logmark)
>      #read_log(logmark)

On Sun, Aug 27, 2017 at 06:06:16PM +0200, Christian Boltz wrote:
> This parameter is always [], so we can simplify the ReadLog __init__()
> parameters.
> 
> Note that some tests handed over '' instead of []. This was a bug, but
> didn't matter because those tests only use a small portion of ReadLog.

> -    log_reader = apparmor.logparser.ReadLog(log_pid, logfile, 
> existing_profiles, profile_dir, [])
> +    log_reader = apparmor.logparser.ReadLog(log_pid, logfile, 
> existing_profiles, profile_dir)

Hah, I love it. The first patch introduced something I was worried about
and then the second patch fixes it :)

Both are

Acked-by: Seth Arnold <seth.arn...@canonical.com>

Thanks

Attachment: signature.asc
Description: PGP signature

-- 
AppArmor mailing list
AppArmor@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/apparmor

Reply via email to