Would a subject like “[PATCH v2] apparmor: Simplify a return statement in 
unpack_perm()”
be more appropriate?


> Fix: delate duplicate logical judgments:
> aa_unpack_u32(e, &perm->allow, NULL);

Would the following wording be a bit nicer?


A conjunction was used with two identical subexpressions.
Thus reduce such an expression to a required computation
in this function implementation.


> Please check this. Thank you!

Such information does usually not belong to a change description.

Regards,
Markus

Reply via email to