[apparmor] [PATCH mptcp-next v12 3/5] selftests/bpf: Add two mptcp netns helpers

[Geliang Tang]

Add two netns helpers for mptcp tests: create_netns() and
cleanup_netns(). Use them in test_base().

These new helpers will be re-used in the following commits introducing
new tests.

Acked-by: Yonghong Song <yonghong.s...@linux.dev>
Reviewed-by: Matthieu Baerts <matthieu.bae...@tessares.net>
Signed-off-by: Geliang Tang <geliang.t...@suse.com>
---
 .../testing/selftests/bpf/prog_tests/mptcp.c  | 37 ++++++++++++-------
 1 file changed, 24 insertions(+), 13 deletions(-)

diff --git a/tools/testing/selftests/bpf/prog_tests/mptcp.c 
b/tools/testing/selftests/bpf/prog_tests/mptcp.c
index b2d41024c6c2..51cbd1e14156 100644
--- a/tools/testing/selftests/bpf/prog_tests/mptcp.c
+++ b/tools/testing/selftests/bpf/prog_tests/mptcp.c
@@ -22,6 +22,27 @@ struct mptcp_storage {
        char ca_name[TCP_CA_NAME_MAX];
 };
 
+static struct nstoken *create_netns(void)
+{
+       srand(time(NULL));
+       snprintf(NS_TEST, sizeof(NS_TEST), "mptcp_ns_%d", rand());
+       SYS(fail, "ip netns add %s", NS_TEST);
+       SYS(fail, "ip -net %s link set dev lo up", NS_TEST);
+
+       return open_netns(NS_TEST);
+fail:
+       return NULL;
+}
+
+static void cleanup_netns(struct nstoken *nstoken)
+{
+       if (nstoken)
+               close_netns(nstoken);
+
+       SYS_NOFAIL("ip netns del %s &> /dev/null", NS_TEST);
+       SYS_NOFAIL("ip netns show %s", NS_TEST);
+}
+
 static int verify_tsk(int map_fd, int client_fd)
 {
        int err, cfd = client_fd;
@@ -147,13 +168,8 @@ static void test_base(void)
        if (!ASSERT_GE(cgroup_fd, 0, "test__join_cgroup"))
                return;
 
-       srand(time(NULL));
-       snprintf(NS_TEST, sizeof(NS_TEST), "mptcp_ns_%d", rand());
-       SYS(fail, "ip netns add %s", NS_TEST);
-       SYS(fail, "ip -net %s link set dev lo up", NS_TEST);
-
-       nstoken = open_netns(NS_TEST);
-       if (!ASSERT_OK_PTR(nstoken, "open_netns"))
+       nstoken = create_netns();
+       if (!ASSERT_OK_PTR(nstoken, "create_netns"))
                goto fail;
 
        /* without MPTCP */
@@ -176,12 +192,7 @@ static void test_base(void)
        close(server_fd);
 
 fail:
-       if (nstoken)
-               close_netns(nstoken);
-
-       SYS_NOFAIL("ip netns del " NS_TEST " &> /dev/null");
-       SYS_NOFAIL("ip netns show %s", NS_TEST);
-
+       cleanup_netns(nstoken);
        close(cgroup_fd);
 }
 
-- 
2.35.3