Hello, On Fri, 2026-03-27 at 19:58 +0800, Daniel J Blueman wrote: > This was introduced by previous incorrect conversion from strcpy(). Fix it > by adding the missing terminator. >
Looks good to me, Reviewed-by: Georgia Garcia <[email protected]> > Cc: [email protected] > Signed-off-by: Daniel J Blueman <[email protected]> > Fixes: 93d4dbdc8da0 ("apparmor: Replace deprecated strcpy in > d_namespace_path") > --- > security/apparmor/path.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/security/apparmor/path.c b/security/apparmor/path.c > index 65a0ca5cc1bd..2494e8101538 100644 > --- a/security/apparmor/path.c > +++ b/security/apparmor/path.c > @@ -164,14 +164,16 @@ static int d_namespace_path(const struct path *path, > char *buf, char **name, > } > > out: > - /* Append "/" to directory paths, except for root "/" which > - * already ends in a slash. > + /* Append "/" to directory paths and reterminate string, except for > + * root "/" which already ends in a slash. > */ > if (!error && isdir) { > bool is_root = (*name)[0] == '/' && (*name)[1] == '\0'; > > - if (!is_root) > + if (!is_root) { > buf[aa_g_path_max - 2] = '/'; > + buf[aa_g_path_max - 1] = '\0'; > + } > } > > return error; > -- > 2.53.0
