On 05/16/2011 07:08 PM, Dan McGee wrote:
On Mon, May 16, 2011 at 4:55 PM, Gerardo Exequiel Pozzi
<[email protected]> wrote:
On 05/16/2011 04:59 PM, Dieter Plaetinck wrote:
On Mon, 16 May 2011 12:57:28 -0300
Gerardo Exequiel Pozzi<[email protected]> wrote:
Signed-off-by: Gerardo Exequiel Pozzi<[email protected]>
---
configs/syslinux-iso/download-repo.sh | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/configs/syslinux-iso/download-repo.sh
b/configs/syslinux-iso/download-repo.sh
index 255304e..78ce531 100755
--- a/configs/syslinux-iso/download-repo.sh
+++ b/configs/syslinux-iso/download-repo.sh
@@ -38,7 +38,8 @@ fi
/usr/bin/pacman -Sy
#Ensure we have core/pkgname format, so we don't get crap from other
repos
-PKGS=$(/usr/bin/pacman -Sl $REPO | cut -d' ' -f1,2 | tr ' ' '/')
+#Workaround remove gcc-add gcc-fortran gcc-go gcc-objc from [core]
it's gcc-ada, not gcc-add. maybe also explain _why_ the workaround is
needed.
brb!!! typo again!.
+PKGS=$(/usr/bin/pacman -Sl $REPO | grep -v "gcc-\(a\|f\|g\|o\)" | cut
-d' ' -f1,2 | tr ' ' '/')
i would list them explicitly, that's more clear and more robust
I would also not list them twice in this script.
With that said, you've taken a totally job-agnostic script and hacked
it to death for only [core], and it will do really silly things when
maybe someone does want to download a full repo without exceptions.
Why aren't you doing this in a more sane fashion outside of the script
itself? I know this is going to be a bit of a hack wherever it ends
up, but this is the wrong place to do it.
dmcgee@galway ~/projects/archiso/configs/syslinux-iso (master)
$ grep 'core' download-repo.sh | wc -l
0
Yes, this is really bad.
Maybe a newer script just for core-workaround ?
if [ -n "$PKGS" ]; then
baseurl=""
@@ -58,7 +59,13 @@ if [ -n "$PKGS" ]; then
fi
done
if [ "$REPO_CHANGED" = "y" ]; then
- wget -nv "$baseurl/$REPO.db" -O "$DEST/$REPO.db"
+ # wget -nv "$baseurl/$REPO.db" -O "$DEST/$REPO.db"
+ #[workaround] remove gcc-add gcc-fortran gcc-go gcc-objc from
[core]
gcc-ada. also, why leave the commented entry?
wget comment? when workaround will be not needed, should be uncomented
again.
+ wget -nv "$baseurl/$REPO.db.tar.gz" -O "$DEST/$REPO.db.tar.gz"
+ repo-remove "$DEST/$REPO.db.tar.gz" gcc-ada gcc-fortran gcc-go
gcc-objc
+ mv "$DEST/$REPO.db.tar.gz" "$DEST/$REPO.db"
+ rm "$DEST/$REPO.db.tar.gz.old"
+ #[/workaround]
fi
else
echo "No packages to download... what'd you break?"
Thanks for the feedback.
So do you finally agree with this?
--
Gerardo Exequiel Pozzi
\cos^2\alpha + \sin^2\alpha = 1
--
Gerardo Exequiel Pozzi
\cos^2\alpha + \sin^2\alpha = 1
