On Sun, Apr 15, 2012 at 20:07, Gerardo Exequiel Pozzi <[email protected]> wrote: > On 04/15/2012 07:27 AM, Dieter Plaetinck wrote: >> >> On Fri, 13 Apr 2012 17:18:40 -0300 >> Gerardo Exequiel Pozzi<[email protected]> wrote: >> >>> - extrapkgs="vim mc base-devel git svn cvs mkinitcpio libisoburn >>> squashfs-tools devtools libui-sh" >>> + extrapkgs="vim mc base-devel git svn cvs mkinitcpio libisoburn >>> squashfs-tools dosfstools devtools libui-sh" >>> >>> otherwise x86_64 isos does not build. >>> >> commit message could be a bit more useful. why would it not build >> otherwise? what's contained within dosfstools that's needed? >> > > ** For configs/releng build.sh needs theses packages (build host): > + dosfstools for mkfs.vfat > > > > -- > Gerardo Exequiel Pozzi > \cos^2\alpha + \sin^2\alpha = 1 >
Isn't this something trivial? When you guys decided to merge efistub booting, and when it is clear that the script requires mkfs.vfat, shouldn't the package that provides mkfs.vfat be included, along with that patch. You have added efibootmgr that is required only during runtime, but left out (initially) dosfstools that is required for iso generation scripts in the first place. Why do it in two separate steps? Regards. Keshav
