On Mon, Dec 09, 2013 at 09:57:27AM +0200, Livnat Peer wrote: > On 12/08/2013 06:32 PM, Moti Asayag wrote: > > > > > > ----- Original Message ----- > >> From: "Livnat Peer" <lp...@redhat.com> > >> To: "Moti Asayag" <masa...@redhat.com>, "arch" <arch@ovirt.org> > >> Sent: Sunday, December 8, 2013 4:06:17 PM > >> Subject: Re: Networks label feature > >> > >> On 12/08/2013 03:22 PM, Moti Asayag wrote: > >>> Hi All, > >>> > >>> Another network feature planned for ovirt-engine-3.4 is > >>> the network labels [1]. > >>> > >>> Please review and share your feedbacks. > >>> > >>> [1] http://www.ovirt.org/Features/NetworkLabels > >>> > >>> Thanks, > >>> Moti > >> > >> Hi Moti, > >> > >> Thanks for writing a detailed feature page, good work. > >> > >> I have a few questions - > >> > >> 1. What does it mean to rename a network label. How does it work with > >> the fact that label is not a managed entity. > >> "Renaming a network label" - It seems from the document that you meant > >> edit network label (instead of rename), and why do we want to add that > >> unpredictable action in the first phase? I would start without this option. > >> > > > > > > The network labels related actions will be executed either from the add/edit > > network dialog by editing the 'label' property, or by editing the label of > > 'interface/bond' on the 'setup networks' dialog. Since the label designed to > > be a plan text property on the network, renaming it means changing its value > > to other. Removing a label stands for clearing this field. > > > > So I guess it all about terminology, I think that since we are not > managing labels as entities we can't rename them, what we do is edit the > label on the network, changing one label to another.
I understand the added complexity of managing a Label as an entity, but do we have an experience with a user-editable foreign key like this? My concern is that an American defines a GRAY label, attaches it to host nics, while an English starts to use GREY on another set of hosts. Understanding why a network is deployed only to some of the hosts may be hard, and fixing the spelling on multiple dialogs is going to be frustrating. _______________________________________________ Arch mailing list Arch@ovirt.org http://lists.ovirt.org/mailman/listinfo/arch