Harsha, One thing to make clear. When we apply a patch once. It is not needed to reapply that every time the server starts. Its already applied the first time, unless the user removes the patch dir and restart the server with -DappyPatches (as of now). Hope I made things clear.
thanks, On Fri, Jun 21, 2013 at 5:53 AM, Harsha Thirimanna <[email protected]> wrote: > Hi, > But if user wants to test some scenario without applying patches , then it > will be good that having such an option easily. This is an optional case, > so not effected to be complicated default scenario. > And if we removed that option that mean we remove our already available > feature. > > > > On Thu, Jun 20, 2013 at 11:40 PM, Supun Malinga <[email protected]> wrote: > >> >> >> >> On Thu, Jun 20, 2013 at 11:29 PM, Shameera Rathnayaka >> <[email protected]>wrote: >> >>> Hi Supun, >>> >>> On Thu, Jun 20, 2013 at 11:14 PM, Supun Malinga <[email protected]> wrote: >>> >>>> >>>> One thing is, we need to be specially careful that what the patch >>>> automation does is clearly visible to the users. This involves proper >>>> logging (I think we already ave this in a separate log), and also in the >>>> main log just put an entry saying some change in the patches is detected >>>> and we are going to apply patches, check this log for more info. >>>> WDYT? >>>> >>> >>> +1 , With current implementation we already have this kind of logging, >>> server startup console prints user friendly messages(INFO and WARN) e.g >>> count of new patches, count of reverted patches, etc ... What we need is to >>> change the messages according to the new implementation. >>> >> great !. >> >> thanks, >> >>> >>> Thanks, >>> Shameera. >>> >>> >>>> >>>> thanks, >>>> >>>> >>>> On Thu, Jun 20, 2013 at 9:25 PM, Amila Suriarachchi <[email protected]>wrote: >>>> >>>>> >>>>> >>>>> >>>>> On Thu, Jun 20, 2013 at 6:31 PM, Harsha Thirimanna >>>>> <[email protected]>wrote: >>>>> >>>>>> hi, >>>>>> +1 , now it is default apply the patches. >>>>>> how about if we can give a command like "-DignorePatches" to run >>>>>> server with out applying the patches without touching patches folder by >>>>>> manual. >>>>>> >>>>> It is like this. if you need to deploy a service we put that under >>>>> service folder. If not we remove it. Same as for third party jars. So for >>>>> patches also if someone copy the patch to patch folder server has to apply >>>>> it. if user don't want they can remove that. >>>>> >>>>> thanks, >>>>> Amila. >>>>> >>>>> >>>>>> On Jun 20, 2013 4:54 PM, "Shameera Rathnayaka" <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hi devs, >>>>>>> >>>>>>> Idea is to remove -DapplyPatches option from server startup. If user >>>>>>> put new patches or remove existing patches to and from >>>>>>> repository/components/patches directory, what he simply need is to apply >>>>>>> those changes. We can automate this process with the implemented patch >>>>>>> application and verification process as we can identify new patches and >>>>>>> reverted patches at server startup. server automatically activate patch >>>>>>> application process if there is any patch changes(add or remove) in >>>>>>> repository/components/patches when server starts. User don't need to >>>>>>> provide -DapplyPatches with startup and server intelligently handle it. >>>>>>> Hence we can get rid of -DapplyPatches parameter. >>>>>>> >>>>>>> Existing patch application and verification keep as it is , that >>>>>>> means if there is any verification problem still it prints warn in >>>>>>> startup >>>>>>> and log to patches.log file more details as well. >>>>>>> >>>>>>> WDYT? >>>>>>> >>>>>>> Thanks, >>>>>>> Shameera. >>>>>>> >>>>>>> *Software Engineer - WSO2 Inc.* >>>>>>> *email: shameera AT wso2.com <[email protected]> , shameera AT >>>>>>> apache.org <[email protected]>* >>>>>>> *phone: +9471 922 1454* >>>>>>> * >>>>>>> * >>>>>>> *Linked in : * >>>>>>> http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561 >>>>>>> *Twitter : *https://twitter.com/Shameera_R >>>>>>> >>>>>>> _______________________________________________ >>>>>>> Architecture mailing list >>>>>>> [email protected] >>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>>> >>>>>>> >>>>>> _______________________________________________ >>>>>> Architecture mailing list >>>>>> [email protected] >>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Amila Suriarachchi* >>>>> >>>>> Software Architect >>>>> WSO2 Inc. ; http://wso2.com >>>>> lean . enterprise . middleware >>>>> >>>>> phone : +94 71 3082805 >>>>> >>>>> _______________________________________________ >>>>> Architecture mailing list >>>>> [email protected] >>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>> >>>>> >>>> >>>> >>>> -- >>>> Supun Malinga, >>>> >>>> Senior Software Engineer, >>>> WSO2 Inc. >>>> http://wso2.com >>>> http://wso2.org >>>> email - [email protected] <[email protected]> >>>> mobile - 071 56 91 321 >>>> >>>> _______________________________________________ >>>> Architecture mailing list >>>> [email protected] >>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>> >>>> >>> >>> >>> -- >>> *Software Engineer - WSO2 Inc.* >>> *email: shameera AT wso2.com <[email protected]> , shameera AT >>> apache.org <[email protected]>* >>> *phone: +9471 922 1454* >>> * >>> * >>> *Linked in : *http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561 >>> *Twitter : *https://twitter.com/Shameera_R >>> >>> _______________________________________________ >>> Architecture mailing list >>> [email protected] >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>> >>> >> >> >> -- >> Supun Malinga, >> >> Senior Software Engineer, >> WSO2 Inc. >> http://wso2.com >> http://wso2.org >> email - [email protected] <[email protected]> >> mobile - 071 56 91 321 >> >> _______________________________________________ >> Architecture mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> >> > > > -- > > *Harsha Thirimanna* > Senior Software Engineer; WSO2, Inc.; http://wso2.com > * <http://www.apache.org/>** > email: **[email protected]* <[email protected]>* cell: +94 71 5186770 > blog: *http://www.mind4web.org/ <http://www.apache.org/>* > twitter: **http://twitter.com/ <http://twitter.com/afkham_azeez>** > harshathirimann > linked-in: **http: <http://lk.linkedin.com/in/afkhamazeez>**// > www.linkedin.com/pub/harsha-thirimanna/10/ab8/122* > * > * > *Lean . Enterprise . Middleware* > * > * > > _______________________________________________ > Architecture mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture > > -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com http://wso2.org email - [email protected] <[email protected]> mobile - 071 56 91 321
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
