Hi Paul, +1 to reflect the changes back to the community. Will get in touch with their mailing list.
Also next line item is to test the flows using the Interop test suite. Will get back to you with the results ASAP. Thanks, Pamod On Saturday, March 8, 2014, Paul Fremantle <p...@wso2.com> wrote: > Pamod > The ideal situation is to aim to get these changes back into Moquette. That means (a) getting them into a shape where they are generically useful to the Moquette community - so that other people wishing to embed Moquette would also look at this and say "yes please", and (b) persuading the Moquette group this is a valuable change/addition. > Is there any chance of doing an interop test with a beta on the 17th March at EclipseCon? I'll be at the interop day. > Paul > > On 8 March 2014 05:36, Pamod Sylvester <pa...@wso2.com> wrote: > > Hi Samisa, > Yes we did changes which are local to the Moquette library, However, the changes were done in a separate class to act as an interface between the Andes Kernal and the MQTT library. All the changes which are specific for the kernel integration are embedded in that class, so that when the library updates with a minimum effort we could adopt to the changes. > However, it was also considered to totally abstract the library without having us modify any of its content but rather call only its interfaces. Then the challenge was to have a way to resolve circular dependencies. Where, > to start the MQTT server MQTT library will depend on Andes and for message exchange Andes will depend on MQTT library. > Also, IMO in order to maintain patches which we also need to have the library source code in a separate branch and maintain the way we do for Synapse. Please do correct me if i am wrong. > Thanks, > Pamod > > > On Sat, Mar 8, 2014 at 10:35 AM, Samisa Abeysinghe <sam...@wso2.com> wrote: > > > > On Sat, Mar 8, 2014 at 10:00 AM, Pamod Sylvester <pa...@wso2.com> wrote: > > Hi All, > The following is the status of the MQTT Moquette library integration with MB 3.0.0, > ~ Library was revamped to fit in with the Andes kernel. > > Have we done local changes in this re-vamp? How do we plan to maintain those if yes? > > > Attached diagram depicts how the messages are flowed between the components at a high level. > ~ Implemented a MQTT client for subscription and publishing. > ~ Also the Moquette library was patched, the default behaviour of the library did not support multiple subscribers to receive a published message. > > How do we plan to maintain these patches? > > > That was due to a bug which had a common ByteBuffer shared between concurrently accessing subscriber connections. The issue was fixed by cloning ByteBuffer instances per subscriber. Note that the wrapped array element was not duplicated or changed. > The implemented code and artefacts could be found in [1]. Will commit the code once reviewed. > To-Dos > ~Need to package the dependencies. > - Need to prepare test cases that would cover all the aspects described in the MQTT spec. > - Need to test MQTT use cases in a cluster. > - Need to load test and perform a long running test. > - Need to discuss on the UI aspects. > Please do let know if there're amendments to be made. > Thanks, > Pamod > [1] https://svn.wso2.org/repos/wso2/scratch/pamod/mqtt_wrok/ > > -- > Pamod Sylvester > Software Engineer > Integration Technologies Team, WSO2 Inc.; http://wso2.com > email: pa...@wso2.com cell: +94 77 7779495 > _______________________________________________ > Architecture mailing list > Architecture@wso2.org > > Paul Fremantle > CTO and Co-Founder, WSO2 > OASIS WS-RX TC Co-chair, Apache Member > > UK: +44 207 096 0336 > US: +1 646 595 7614 > > blog: http://pzf.fremantle.org > twitter.com/pzfreo > p...@wso2.com > wso2.com Lean Enterprise Middleware > > Disclaimer: This communication may contain privileged or other confidential information and is intended exclusively for the addressee/s. If you are not the intended recipient/s, or believe that you may have received this communication in error, please reply to the sender indicating that fact and delete the copy you received and in addition, you should not print, copy, retransmit, disseminate, or otherwise use the information contained in this communication. Internet communications cannot be guaranteed to be timely, secure, error or virus-free. The sender does not accept liability for any errors or omissions. -- *Pamod Sylvester * * Software Engineer * Integration Technologies Team, WSO2 Inc.; http://wso2.com email: pa...@wso2.com cell: +94 77 7779495
_______________________________________________ Architecture mailing list Architecture@wso2.org https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
