Hi shakila, I see there are some miss matching on the standard that we follow, Hence please correct the changes on bellow mention item as we discussed
1) Change the Init Method to get the token from the user(Currently it is hard coded) 2) Add licensing header 3) Maintain the consistency on naming on methods. 4) Add .ignore file for git 5) Change the README file with more accurate information. example :- 6) Add the integration test information into the given document. 7) All the files should be modified and intent correctly On Mon, Dec 8, 2014 at 4:23 PM, Vanjikumaran Sivajothy <va...@wso2.com> wrote: > Hi Shakila, > > Please give me access to comment on your document. > > Thank you, > Best Regards, > Vanji > > On Mon, Dec 8, 2014 at 3:46 PM, Samisa Abeysinghe <sam...@wso2.com> wrote: > >> Please have the final review and see what the outcomes are... >> >> Thanks, >> Samisa... >> >> >> Samisa Abeysinghe >> >> Vice President Delivery >> >> WSO2 Inc. >> http://wso2.com >> >> >> On Mon, Dec 8, 2014 at 3:39 PM, Shakila Sivagnanarajah <shak...@wso2.com> >> wrote: >> >>> Hi all, >>> >>> According to the milestone plan given in [1], the implementation is >>> completed. >>> >>> Since there are two operations listed in [2] depend on actual nest >>> device, the relevant automated test cases of those methods are not >>> included. >>> >>> Please find the git-hub repository [3] and documentation [4] given below. >>> >>> [1] >>> https://docs.google.com/a/wso2.com/spreadsheets/d/18OxjEOnd02DQCQi2LM_dGhP1Gy-JBjHYfnHofXBvlM4/edit#gid=0 >>> >>> [2] View last connection information(of Thermostat) and View last >>> manual test status (of Smoke + CO alarm). >>> >>> [3] https://github.com/Shakila/NestESBConnector >>> >>> [4] >>> https://docs.google.com/a/wso2.com/document/d/18OcKKkARdJEH80Wzs-j9IeZw6Gp561QWi-rGje9hXEI/edit >>> >>> >>> Thank you. >>> >>> -- >>> Shakila Sivagnanarajah >>> Associate Software Engineer >>> Mobile :+94 (0) 770 760240 >>> shak...@wso2.com >>> >> >> > > > -- > Sivajothy Vanjikumaran > *Senior Software Engineer* > *Integration Technologies Team* > *WSO2 Inc. http://wso2.com <http://wso2.com/>* > *Mobile:(+94)777219209* > [image: Facebook] <https://www.facebook.com/vanjikumaran> [image: Twitter] > <https://twitter.com/vanjikumaran> [image: LinkedIn] > <http://www.linkedin.com/pub/vanjikumaran-sivajothy/25/b31/293> [image: > Blogger] <http://vanjikumaran.blogspot.com/> [image: SlideShare] > <http://www.slideshare.net/vanjikumaran> > > This communication may contain privileged or other > confidential information and is intended exclusively for the addressee/s. > If you are not the intended recipient/s, or believe that you may > have received this communication in error, please reply to the > sender indicating that fact and delete the copy you received and in > addition, you should not print, copy, re-transmit, disseminate, or > otherwise use the information contained in this communication. > Internet communications cannot be guaranteed to be timely, secure, error > or virus-free. The sender does not accept liability for any errors > or omissions > -- Sivajothy Vanjikumaran *Senior Software Engineer* *Integration Technologies Team* *WSO2 Inc. http://wso2.com <http://wso2.com/>* *Mobile:(+94)777219209* [image: Facebook] <https://www.facebook.com/vanjikumaran> [image: Twitter] <https://twitter.com/vanjikumaran> [image: LinkedIn] <http://www.linkedin.com/pub/vanjikumaran-sivajothy/25/b31/293> [image: Blogger] <http://vanjikumaran.blogspot.com/> [image: SlideShare] <http://www.slideshare.net/vanjikumaran> This communication may contain privileged or other confidential information and is intended exclusively for the addressee/s. If you are not the intended recipient/s, or believe that you may have received this communication in error, please reply to the sender indicating that fact and delete the copy you received and in addition, you should not print, copy, re-transmit, disseminate, or otherwise use the information contained in this communication. Internet communications cannot be guaranteed to be timely, secure, error or virus-free. The sender does not accept liability for any errors or omissions
_______________________________________________ Architecture mailing list Architecture@wso2.org https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
