README has been fixed On Tue, May 24, 2016 at 1:28 AM, Senaka Fernando <sen...@wso2.com> wrote:
> > > On Mon, May 23, 2016 at 8:57 PM, Senaka Fernando <sen...@wso2.com> wrote: > >> Hi Azeez, >> >> Thanks for getting back. Sorry I was in a hurry putting a demo together >> for Thursday - reading your replies, I see that I haven't explained a few >> things. >> >> On Mon, May 23, 2016 at 7:42 PM, Afkham Azeez <az...@wso2.com> wrote: >> >>> >>> >>> On Tue, May 24, 2016 at 12:10 AM, Afkham Azeez <az...@wso2.com> wrote: >>> >>>> >>>> >>>> On Mon, May 23, 2016 at 9:42 PM, Senaka Fernando <sen...@wso2.com> >>>> wrote: >>>> >>>>> Hi all, >>>>> >>>>> I'm working on pulling a demo together based on $subject. So, good >>>>> news is that it works nearly perfectly. But, then there were a few things >>>>> that I noted. >>>>> >>>>> 1. API-M is unable to process the Swagger URL presented by MSF4J >>>>> (due to inverted commas, AFAIU). >>>>> >>>>> What inverted commas? Swagger URL is like this: >>>> >>>> http://localhost:8080/swagger?path=/stockquote >>>> >>> >> That works. Sorry - I should have tried that. But, we have to fix the >> README(s), [1]. >> > > Sorry, [1] > https://github.com/wso2/msf4j/blob/master/samples/stockquote/fatjar/README.md > > >> The URL points to the right place, but the text is wrong. >> >> I copied that and didn't think much since the file import worked well. >> Also, the microservice responds with and without inverted commas (i.e. curl >> http://localhost:8080/swagger?path=/stockquote > 1.out; curl >> http://localhost:8080/swagger?path="/stockquote"; > 2.out; diff 1.out >> 2.out). >> >>> >>>> >>>>> >>>>> 1. It parses the Swagger file well, but there were two issues: >>>>> 1. It uses the Title and the default one presented by MSF4J has >>>>> spaces and won't work - (so had to fix the sample - but that's >>>>> fine). >>>>> >>>>> >>>> Can you post an example? >>>> >>> >>> Did you mean this: "title" : "Stockquote Swagger Definition" >>> >> >> Yes, that is what I meant. I fixed this in the >> src/main/java/org/wso2/msf4j/example/StockQuoteService.java class to >> "StockQuote". May be it is not an issue of MSF4J, but API-M. But, if you >> try to create a new API with >> http://localhost:8080/swagger?path=/stockquote as the Swagger URL, API-M >> fails. >> >>> >>>> >>>>> >>>>> 1. >>>>> 2. It doesn't extract the context from the Swagger file >>>>> appropriately, but appends that into the resources on the API >>>>> definition. >>>>> So, if you stick to the defaults, the URL looks a little ugly, " >>>>> http://localhost:8280/*stockquote*/1.0/*stockquote*/IBM"; >>>>> >>>>> For the point above of course, I didn't find any workaround. >> >> Thanks, >> Senaka. >> >>> >>>>> 1. >>>>> >>>>> Are these things for which we have fixes/workarounds? >>>>> >>>>> Thanks, >>>>> Senaka. >>>>> -- >>>>> >>>>> >>>>> *[image: http://wso2.com] <http://wso2.com>Senaka Fernando* >>>>> Solutions Architect; WSO2 Inc.; http://wso2.com >>>>> >>>>> >>>>> >>>>> *Member; Apache Software Foundation; http://apache.org >>>>> <http://apache.org>E-mail: senaka AT wso2.com <http://wso2.com>**P: >>>>> +44 203 318 6025 <%2B44%20203%20318%206025>;* >>>>> >>>>> >>>>> *M: +44 782 741 1966 <%2B44%20782%20741%201966>Linked-In: >>>>> http://linkedin.com/in/senakafernando >>>>> <http://linkedin.com/in/senakafernando>*Lean . Enterprise . Middleware >>>>> >>>> >>>> >>>> >>>> -- >>>> *Afkham Azeez* >>>> Director of Architecture; WSO2, Inc.; http://wso2.com >>>> Member; Apache Software Foundation; http://www.apache.org/ >>>> * <http://www.apache.org/>* >>>> *email: **az...@wso2.com* <az...@wso2.com> >>>> * cell: +94 77 3320919 <%2B94%2077%203320919>blog: * >>>> *http://blog.afkham.org* <http://blog.afkham.org> >>>> *twitter: **http://twitter.com/afkham_azeez* >>>> <http://twitter.com/afkham_azeez> >>>> *linked-in: **http://lk.linkedin.com/in/afkhamazeez >>>> <http://lk.linkedin.com/in/afkhamazeez>* >>>> >>>> *Lean . Enterprise . Middleware* >>>> >>> >>> >>> >>> -- >>> *Afkham Azeez* >>> Director of Architecture; WSO2, Inc.; http://wso2.com >>> Member; Apache Software Foundation; http://www.apache.org/ >>> * <http://www.apache.org/>* >>> *email: **az...@wso2.com* <az...@wso2.com> >>> * cell: +94 77 3320919 <%2B94%2077%203320919>blog: * >>> *http://blog.afkham.org* <http://blog.afkham.org> >>> *twitter: **http://twitter.com/afkham_azeez* >>> <http://twitter.com/afkham_azeez> >>> *linked-in: **http://lk.linkedin.com/in/afkhamazeez >>> <http://lk.linkedin.com/in/afkhamazeez>* >>> >>> *Lean . Enterprise . Middleware* >>> >> >> >> >> -- >> >> >> *[image: http://wso2.com] <http://wso2.com>Senaka Fernando* >> Solutions Architect; WSO2 Inc.; http://wso2.com >> >> >> >> *Member; Apache Software Foundation; http://apache.org >> <http://apache.org>E-mail: senaka AT wso2.com <http://wso2.com>**P: +44 >> 203 318 6025 <%2B44%20203%20318%206025>;* >> >> >> *M: +44 782 741 1966 <%2B44%20782%20741%201966>Linked-In: >> http://linkedin.com/in/senakafernando >> <http://linkedin.com/in/senakafernando>*Lean . Enterprise . Middleware >> > > > > -- > > > *[image: http://wso2.com] <http://wso2.com>Senaka Fernando* > Solutions Architect; WSO2 Inc.; http://wso2.com > > > > *Member; Apache Software Foundation; http://apache.org > <http://apache.org>E-mail: senaka AT wso2.com <http://wso2.com>**P: +44 > 203 318 6025 <%2B44%20203%20318%206025>;* > > > *M: +44 782 741 1966 <%2B44%20782%20741%201966>Linked-In: > http://linkedin.com/in/senakafernando > <http://linkedin.com/in/senakafernando>*Lean . Enterprise . Middleware > -- *Afkham Azeez* Director of Architecture; WSO2, Inc.; http://wso2.com Member; Apache Software Foundation; http://www.apache.org/ * <http://www.apache.org/>* *email: **az...@wso2.com* <az...@wso2.com> * cell: +94 77 3320919blog: **http://blog.afkham.org* <http://blog.afkham.org> *twitter: **http://twitter.com/afkham_azeez* <http://twitter.com/afkham_azeez> *linked-in: **http://lk.linkedin.com/in/afkhamazeez <http://lk.linkedin.com/in/afkhamazeez>* *Lean . Enterprise . Middleware*
_______________________________________________ Architecture mailing list Architecture@wso2.org https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
