On Thu, Jun 2, 2016 at 9:43 PM, Isuru Perera <isu...@wso2.com> wrote:
> Hi Suho, > > In Metrics, I have written the DAS Reporter using the data publisher. Do > you think I should change the implementation to use an HTTP client? > We don't need to change from Thrift to HTTP, rather we need to have an intermediate (high-level) layer which does not depend on underneath transport protocol and relevant transport can be configured using a config file (Like we have stream terminology for CEP publisher) . > > We also need to release Metrics soon. So, if we are going to change the > implementation, we need to decide soon. However I think it'll have an > impact on the release schedule for Metrics. > > In Metrics, the DAS reporter is used to store the historical metrics data > in DAS. The reporter will send events periodically (1 minute, by default). > So, do you think we will encounter any issue with current Data Publisher. > Theoretically, I don't think there are any issues but we need tryout.. > > Please let me know. > > Thanks! > > On Thu, Jun 2, 2016 at 3:18 PM, Sriskandarajah Suhothayan <s...@wso2.com> > wrote: > >> Are we going to use data bridge in C5 ? >> C5 have Netty based transports, cant we use one of them to publish events >> to DAS, since DAS have the capability to receiving from any transport >> protocol via extensions this will not be a problem. >> >> In my opinion we should not be depending on data publisher as it have >> several issues like events can get out of ordered, dropped and its not >> reliable. We should have a publishing framework which is independent of the >> transport, so users can pic Thrift, HTTP or AMQP based on their use cases. >> >> WDYT? >> >> Suho >> >> On Thu, Jun 2, 2016 at 2:35 PM, Kishanthan Thangarajah < >> kishant...@wso2.com> wrote: >> >>> A separate point to note. >>> >>> Thinking along the AS 6.0 and C5 aspect, what we need is a library, >>> where we could use that in both OSGi env and non-OSGi environments. It >>> should not have any direct dependency on carbon API's. Currently, with AS >>> 6.0, we are using the data publisher from C4 without any code changes and >>> removing unwanted dependencies. If we planning to write this again, we >>> should come up with the minimum library that could be used in a OSGi and >>> non-OSGi env. >>> >>> >>> On Thu, Jun 2, 2016 at 1:40 PM, Isuru Perera <isu...@wso2.com> wrote: >>> >>>> Hi, >>>> >>>> On Thu, Jun 2, 2016 at 1:10 PM, Sinthuja Ragendran <sinth...@wso2.com> >>>> wrote: >>>> >>>>> Hi IsuruP, >>>>> >>>>> Please find the comments inline. >>>>> >>>>> On Thu, Jun 2, 2016 at 12:18 PM, Isuru Perera <isu...@wso2.com> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> This is regarding $subject and the main problem we have is that there >>>>>> is no Carbon 5 compatible feature for data bridge agent. >>>>>> >>>>> >>>>> Data bridge agent publisher is not depends on carbon, and it has some >>>>> dependencies for carbon utils, and carbon base, which we can eliminate by >>>>> passing proper configurations in data-agent-config.xml. >>>>> >>>> Yes. This is what should be done. >>>> >>>> I think we should avoid carbon dependencies in data publisher. We can >>>> have some Carbon specific component to initialize data publisher in Carbon >>>> (OSGi) environment. >>>> >>>>> In that case, what do you mean by it's not compatible by Carbon 5 as >>>>> it's anyhow doesn't depend on carbon features? >>>>> >>>> As I mentioned earlier, the publisher has Carbon 4.x dependencies. So, >>>> we need to workaround problems like NoClassDefFoundError for >>>> CarbonUtils etc. >>>> >>>>> >>>>> >>>>>> >>>>>> Since Data Bridge Agent is already an OSGi bundle, we can use it >>>>>> within C5 products. But we have to include it with some feature. >>>>>> >>>>>> For example, Carbon Metrics needs to publish events to DAS. So, is it >>>>>> okay if I keep data bridge agent in Metrics feature? >>>>>> >>>>> >>>>> No, I don't think that is a good option. Because the publisher is a >>>>> generic feature, and it doesn't have any relation ship to metrics feature >>>>> other then metrics feature is using data publisher feature. In that case, >>>>> you need to have just importFeature defn for the datapublisher feature >>>>> form >>>>> the metrics feature. >>>>> >>>> Yes. The correct way is to import data publisher feature. However there >>>> is no such feature available now. Since Metrics needs the publisher >>>> dependencies, I thought we can include those dependencies until we have a >>>> data publisher designed to work with C5. When someone wants to install >>>> metrics feature, it should work without any issue. Right now, I cannot do a >>>> release of Carbon Metrics till I have answers to the questions raised in >>>> this mail thread. >>>> >>>>> >>>>> >>>>>> >>>>>> Other problem is that the current Data Bridge Agent is written for >>>>>> Carbon 4.x based products. For example it uses CarbonUtils to find the >>>>>> location of data-agent-config.xml. The CarbonUtils class used by the >>>>>> agent >>>>>> is only available in C4. >>>>>> >>>>>> We can avoid this by giving a configuration file to the agent. Then >>>>>> there will be no NoClassDefFoundError. However as the next step, the >>>>>> agent >>>>>> requires the client-trustore.jks and the password to the truststore. >>>>>> >>>>>> How should we give the trust store configuration in Carbon 5? For >>>>>> now, we use the system properties: javax.net.ssl.trustStore and >>>>>> javax.net.ssl.trustStorePassword. >>>>>> >>>>> >>>>> I think in C5 also the above mentioned system properties will be >>>>> exposed, anyhow I'm not sure though. Anyhow you can set above >>>>> configuration >>>>> from data-agent-config.xml as well, so you may have it in the static >>>>> location now. >>>>> >>>> Yes. We can do that as well. >>>> >>>> Thanks! >>>> >>>>> >>>>> Thanks, >>>>> Sinthuja. >>>>> >>>>> >>>>>> The Message Broker is trying to use Carbon Metrics for analytics and >>>>>> we need to know what are the recommendations for using Data Bridge Agent >>>>>> in >>>>>> C5. >>>>>> >>>>> >>>>>> Thanks, >>>>>> >>>>>> Best Regards, >>>>>> >>>>>> -- >>>>>> Isuru Perera >>>>>> Associate Technical Lead | WSO2, Inc. | http://wso2.com/ >>>>>> Lean . Enterprise . Middleware >>>>>> >>>>>> about.me/chrishantha >>>>>> Contact: +IsuruPereraWSO2 >>>>>> <https://www.google.com/+IsuruPereraWSO2/about> >>>>>> >>>>>> _______________________________________________ >>>>>> Architecture mailing list >>>>>> Architecture@wso2.org >>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Sinthuja Rajendran* >>>>> Associate Technical Lead >>>>> WSO2, Inc.:http://wso2.com >>>>> >>>>> Blog: http://sinthu-rajan.blogspot.com/ >>>>> Mobile: +94774273955 >>>>> >>>>> >>>>> >>>>> _______________________________________________ >>>>> Architecture mailing list >>>>> Architecture@wso2.org >>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>> >>>>> >>>> >>>> >>>> -- >>>> Isuru Perera >>>> Associate Technical Lead | WSO2, Inc. | http://wso2.com/ >>>> Lean . Enterprise . Middleware >>>> >>>> about.me/chrishantha >>>> Contact: +IsuruPereraWSO2 >>>> <https://www.google.com/+IsuruPereraWSO2/about> >>>> >>>> _______________________________________________ >>>> Architecture mailing list >>>> Architecture@wso2.org >>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>> >>>> >>> >>> >>> -- >>> *Kishanthan Thangarajah* >>> Technical Lead, >>> Platform Technologies Team, >>> WSO2, Inc. >>> lean.enterprise.middleware >>> >>> Mobile - +94773426635 >>> Blog - *http://kishanthan.wordpress.com >>> <http://kishanthan.wordpress.com>* >>> Twitter - *http://twitter.com/kishanthan >>> <http://twitter.com/kishanthan>* >>> >>> _______________________________________________ >>> Architecture mailing list >>> Architecture@wso2.org >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>> >>> >> >> >> -- >> >> *S. Suhothayan* >> Technical Lead & Team Lead of WSO2 Complex Event Processor >> *WSO2 Inc. *http://wso2.com >> * <http://wso2.com/>* >> lean . enterprise . middleware >> >> >> *cell: (+94) 779 756 757 <%28%2B94%29%20779%20756%20757> | blog: >> http://suhothayan.blogspot.com/ <http://suhothayan.blogspot.com/>twitter: >> http://twitter.com/suhothayan <http://twitter.com/suhothayan> | linked-in: >> http://lk.linkedin.com/in/suhothayan <http://lk.linkedin.com/in/suhothayan>* >> >> _______________________________________________ >> Architecture mailing list >> Architecture@wso2.org >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> >> > > > -- > Isuru Perera > Associate Technical Lead | WSO2, Inc. | http://wso2.com/ > Lean . Enterprise . Middleware > > about.me/chrishantha > Contact: +IsuruPereraWSO2 <https://www.google.com/+IsuruPereraWSO2/about> > > _______________________________________________ > Architecture mailing list > Architecture@wso2.org > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture > > -- *V. Mohanadarshan* *Senior Software Engineer,* *Data Technologies Team,* *WSO2, Inc. http://wso2.com <http://wso2.com> * *lean.enterprise.middleware.* email: mo...@wso2.com phone:(+94) 771117673
_______________________________________________ Architecture mailing list Architecture@wso2.org https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture