Hi All, Isn't it confusing to maintain two analytics repos with both having common analytics stuff?
And even if there is a valid reason to do this, still it seems that the repo names are confusing since both (shared-analytics and carbon-analytics-common) sound the same. Isn't that so? @dunith, +1 to your suggestion. Regards, Dilan. On Friday, June 10, 2016, Tharik Kanaka <tha...@wso2.com> wrote: > Hi All, > > @Damith > These are common libs for portal wizard which is common for analytics > products (analytics-is, analytics-esb, analytics-apim and etc), product-das > and product-cep. shared-analytics repository was created for analytics > products, product-das and product-cep does not have dependencies. > > @Dunith and others > On the other hand keeping these in carbon-analytics-common could cause > maintenance difficulties. For an instance if there is a bug in one of chart > wizard view, we need to fix it carbon-analytics-common and release that and > then need to release all the repositories depending on > carbon-analytics-common. This can be resolved if we keep these in some repo > like shared-analytics and include those features in the products-cep and > product-das. Again then we need reconsider about the name > "shared-analytics" as it has become a common repository for products-cep > and product-das as well. > > Regards, > > On Fri, Jun 10, 2016 at 5:13 PM, Damith Wickramasinghe <dami...@wso2.com > <javascript:_e(%7B%7D,'cvml','dami...@wso2.com');>> wrote: > >> Hi Dunith, >> >> +1 . isn't these should go shared-analytics repository since we are using >> it to hold all common artifacts used in analytics effort. >> >> Regards, >> Damith. >> >> On Fri, Jun 10, 2016 at 4:55 PM, Dunith Dhanushka <dun...@wso2.com >> <javascript:_e(%7B%7D,'cvml','dun...@wso2.com');>> wrote: >> >>> Hi all, >>> >>> Gadgets developed for analytics products (E.g ESB, IS,MB, IoTs etc) >>> depend on JS libraries which are currently been referred from multiple >>> locations. >>> >>> For instance >>> >>> 1. JS utilities common to all gadgets like wso2gadgets.js and >>> chart-utils.js (Currently referred from /portal/libs/common-chart-libs) >>> 2. JS libraries used by chart template authors (related to gadget >>> wizard). E.g VizGrammar, Vega etc (Currently referred from gadget level js >>> folder) >>> >>> Since above JS libraries do tasks specific to analytics (E.g mostly for >>> data visualization), it is better to maintain them in a analytics >>> repository like >>> carbon-analytics-common. Advantage is that a simple change in those JS >>> files will not require a new carbon-dashboards release. >>> >>> Another issue is when generating a gadget, libraries like VizGrammar are >>> packed with each gadget. If there are considerable amount of gadget's >>> exist, it is quite difficult to propagate a library change across all >>> gadgets. >>> >>> So as a solution, we came up like this. >>> >>> 1. There's a feature [1] in carbon-analytics-common to put all analytics >>> UX related artifcats such as chart templates and data providers. We can >>> have a room for JS files as well. >>> >>> 2. All analytics related JS files will be maintained inside [1] and >>> analytics folks will have total control over them. >>> >>> 3. When building an analytics product, required analytics JS files will >>> be copied to /portal/libs/analytics-wso2_1.0 folder (Can be instructed in >>> p2.inf file of feature [1]). >>> >>> 4. Gadgets generated using wizard will refer JS files from above >>> location so that change in one file will be reflected in every generated >>> gadget. >>> E.g /portal/libs/analytics-wso2_1.0/VizGrammar.min.js >>> >>> By this way, carbon-dashboards repo will no longer needing to maintain >>> any analytics specific JS files. >>> >>> @DS Team, @Dakshika can we have your feedback on this please? Suggest a >>> naming standard if possible. >>> >>> [1] >>> https://github.com/wso2/carbon-analytics-common/tree/master/features/analytics-gadget-templates >>> >>> Regards, >>> >>> Dunith Dhanushka, >>> Associate Technical Lead >>> WSO2 Inc, >>> >>> Mobile - +94 71 8615744 >>> Blog - *https://medium.com/@dunithd <https://medium.com/@dunithd>* >>> Twitter - @dunithd <http://twitter.com/dunithd> >>> >>> _______________________________________________ >>> Architecture mailing list >>> Architecture@wso2.org >>> <javascript:_e(%7B%7D,'cvml','Architecture@wso2.org');> >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>> >>> >> >> >> -- >> Software Engineer >> WSO2 Inc.; http://wso2.com >> <http://www.google.com/url?q=http%3A%2F%2Fwso2.com&sa=D&sntz=1&usg=AFQjCNEZvyc0uMD1HhBaEGCBxs6e9fBObg> >> lean.enterprise.middleware >> >> mobile: *+94728671315 <%2B94728671315>* >> >> > > > -- > > *Tharik Kanaka* > > WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka > > Email: tha...@wso2.com <javascript:_e(%7B%7D,'cvml','tha...@wso2.com');> | > Web: www.wso2.com > -- *Dilan U. Ariyaratne* Senior Software Engineer WSO2 Inc. <http://wso2.com/> Mobile: +94766405580 <%2B94766405580> lean . enterprise . middleware
_______________________________________________ Architecture mailing list Architecture@wso2.org https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
