On Thu, Jan 19, 2017 at 2:17 PM, Ruwan Abeykoon <ruw...@wso2.com> wrote:
> Hi All, > @Johann > I think security questions/account recovery options should not be treated > as server-configurations. I would rather consider them as the runtime data > much like the SP/IdP data. Hence single server config does not apply for > this case IMO. > I see your point. In that case we need to visit all the configurations in identity.xml and separate them into server configuration and runtime data and have a single file for server configurations and most probably have a feature wise file for the runtime data. When I say feature wise, we can group related features together and have a single file. Otherwise we may end up having too many small files. E.g. all features in carbon-identity-mgt can read from a single file. Wdyt? > >>Each component must pass its own configuration in the yaml file using > snakeyaml and build its own configuration model. > +1, However with small tweak, we should read the file once and represent > it in JSON raw object model and keep in memory. This will improve startup > time by eliminating many number of file reads. Each component can read > relevant section with JSONPATH or object traversal. > +1 Regards, Johann. > > Cheers, > Ruwan > > > On Thu, Jan 19, 2017 at 2:03 PM, Johann Nallathamby <joh...@wso2.com> > wrote: > >> Hi Danushka, >> >> Did you see [1]? The thread talks about a single config file for the most >> commonly changed config files. However the thread doesn't seem to have a >> conclusion. >> >> @Kernel Team, >> Is this something we have completed implementing? If so can you share >> some latest details of how we should be using it? >> >> @Danushka, >> In any case one mistake we made in C4 based IS is reading and parsing the >> identity.xml from a single component - identity.core. We must not make the >> same mistake again. Each component must pass its own configuration in the >> yaml file using snakeyaml and build its own configuration model. This will >> achieve less coupling among bundles. Of course you can have utilities in >> [2] if needed to pass identity.yaml but nothing specific to a specific >> feature. >> >> So I think to summarize, the configuration file is specific to the >> product and a single file for the whole server, but parsing the file is the >> responsibility of each component. This doesn't apply for more complex >> configurations such as claim-config.yaml, user-store-config.yaml, etc. >> >> [1] [Architecture] Configuration files in C5 >> [2] https://github.com/wso2/carbon-identity-commons/tree/mas >> ter/components/org.wso2.carbon.identity.common/src/main/java >> /org/wso2/carbon/identity/common/util >> >> Regards, >> Johann. >> >> On Thu, Jan 19, 2017 at 1:46 PM, Danushka Fernando <danush...@wso2.com> >> wrote: >> >>> Hi All >>> We are currently working on setting challenge questions feature for IS >>> 6.0.0-M1. We need some configurations specific to security questions / >>> account recovery section. In C4 based products it was in identity.xml which >>> is the server configuration. In C5 code we dont have created a such file. >>> We have several user management related configs which are deployed >>> separately in C4 as well. But when we are moving towards C5, what should be >>> the way of creating these configs. Is it component wise or server wise? >>> >>> Any ideas are appreciated. >>> >>> Thanks & Regards >>> Danushka Fernando >>> Senior Software Engineer >>> WSO2 inc. http://wso2.com/ >>> Mobile : +94716332729 <+94%2071%20633%202729> >>> >> >> >> >> -- >> Thanks & Regards, >> >> *Johann Dilantha Nallathamby* >> Technical Lead & Product Lead of WSO2 Identity Server >> Governance Technologies Team >> WSO2, Inc. >> lean.enterprise.middleware >> >> Mobile - *+94777776950* >> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >> >> _______________________________________________ >> Dev mailing list >> d...@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > > -- Thanks & Regards, *Johann Dilantha Nallathamby* Technical Lead & Product Lead of WSO2 Identity Server Governance Technologies Team WSO2, Inc. lean.enterprise.middleware Mobile - *+94777776950* Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>*
_______________________________________________ Architecture mailing list Architecture@wso2.org https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
