On Sun, Mar 19, 2017 at 2:10 PM, Gayan Gunawardana <ga...@wso2.com> wrote:
>
>
> On Wed, Mar 15, 2017 at 6:50 AM, Thanuja Jayasinghe <than...@wso2.com>
> wrote:
>
>> Hi Nuwandi,
>>
>> On Tue, Mar 14, 2017 at 1:54 PM, Nuwandi Wickramasinghe <
>> nuwan...@wso2.com> wrote:
>>
>>>
>>>
>>> On Tue, Mar 14, 2017 at 12:42 PM, Thanuja Jayasinghe <than...@wso2.com>
>>> wrote:
>>>
>>>> Hi Gayan,
>>>>
>>>> Yes. We need to specially handle username claim("
>>>> http://wso2.org/claims/username";).
>>>>
>>> So, it will always be http://wso2.org/claims/username, not configurable?
>>>
>>
>> I see following performance related concerns if we marked some claim as
>> the username claim using a property,
>>
>>
>>
>> - In every operation which we are going to specially handle for
>> username claim, we need to check that property
>> - If we want to get the username claim value, first we need to go
>> through claims to identify the username claim and then retrieve the value
>> for that claim
>>
>> Also, it will be much easier for the User object to retrieve username
>> claim from a claim URI rather than a property. (We don't have the API
>> support for retrieving claim value from a property)
>>
>> In a case like "email as username", we can still map the username claim
>> to the email attribute. Then we can map the same email attribute to email
>> claim to avoid the confusion.
>>
> if "http://wso2.org/claims/username"; represent username claim always we
> do not need to define it separately in domain-config.yaml right ?
>
Yes.
@Pushpalanka: Are we planning to provide the capability to change root
claim dialect?
>
>>
>>>> Shall we add a method to User[1] class to retrieve username?
>>>>
>>> +1 to have a method in User.java
>>>
>>>>
>>>> [1] - https://github.com/wso2/carbon-identity-mgt/blob/master/com
>>>> ponents/org.wso2.carbon.identity.mgt/src/main/java/org/wso2/
>>>> carbon/identity/mgt/User.java
>>>>
>>>> Thanks,
>>>> Thanuja
>>>>
>>>> On Tue, Mar 14, 2017 at 12:12 PM, Gayan Gunawardana <ga...@wso2.com>
>>>> wrote:
>>>>
>>>>> Hi All,
>>>>>
>>>>> Don't we have to provide an API to get username claim from domain
>>>>> level.
>>>>> I am suggesting to have some thing like
>>>>>
>>>>> org.wso2.carbon.identity.mgt.User userStoreUser = identityStore.
>>>>> getUser(userId);
>>>>> userStoreUser.getUsernameClaim();
>>>>>
>>>>> Currently we handle username claim as just an another claim but it
>>>>> should be treated as special claim because username is the human friendly
>>>>> unique identifier for users.
>>>>>
>>>>> In domain-config.yaml we can define username claim for each domain.
>>>>>
>>>>> Also another requirement is when we get username from out side
>>>>> application, we need to retrieve corresponding user from identity store so
>>>>> we need to set value got from out side to appropriate claim. In that case
>>>>> there should be a way to identify username claim.
>>>>>
>>>>> WDYT?
>>>>>
>>>>> Thanks,
>>>>> Gayan
>>>>>
>>>>>
>>>>> --
>>>>> Gayan Gunawardana
>>>>> Software Engineer; WSO2 Inc.; http://wso2.com/
>>>>> Email: ga...@wso2.com
>>>>> Mobile: +94 (71) 8020933
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> *Thanuja Lakmal*
>>>> Senior Software Engineer
>>>> WSO2 Inc. http://wso2.com/
>>>> *lean.enterprise.middleware*
>>>> Mobile: +94715979891 +94758009992
>>>>
>>>
>>>
>>>
>>> --
>>>
>>> Best Regards,
>>>
>>> Nuwandi Wickramasinghe
>>>
>>> Software Engineer
>>>
>>> WSO2 Inc.
>>>
>>> Web : http://wso2.com
>>>
>>> Mobile : 0719214873
>>>
>>
>> Thanks,
>> Thanuja
>>
>> --
>> *Thanuja Lakmal*
>> Senior Software Engineer
>> WSO2 Inc. http://wso2.com/
>> *lean.enterprise.middleware*
>> Mobile: +94715979891 +94758009992
>>
>
>
>
> --
> Gayan Gunawardana
> Software Engineer; WSO2 Inc.; http://wso2.com/
> Email: ga...@wso2.com
> Mobile: +94 (71) 8020933
>
--
*Thanuja Lakmal*
Senior Software Engineer
WSO2 Inc. http://wso2.com/
*lean.enterprise.middleware*
Mobile: +94715979891 +94758009992
_______________________________________________
Architecture mailing list
Architecture@wso2.org
https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
