In addition, I think it's better for all commits to include a reference to a JIRA issue number. This helps linking the commits so a JIRA issue (as JIRA can automatically link those) and also help preparing release notes or review all the changes from JIRA. Discussions are often capture in JIRA issues, so having a way to easily link a commit to the related discussion really helps imho.
On Thu, Oct 22, 2009 at 21:44, zoe <[email protected]> wrote: > Hi Jeremy >> >> Hi Zoe, >> >> AFAICS there isn't a >> incubator/aries/trunk/blueprint/blueprint-helloworld/pom.xml file so >> blueprint-helloworld isn't built when a full build is done. >> > > Thanks, I'll fix it :-) >> >> Cheers, >> Jeremy >> >> 2009/10/22 <[email protected]>: >> >>> >>> Author: zoe >>> Date: Thu Oct 22 16:52:12 2009 >>> New Revision: 828784 >>> >>> URL: http://svn.apache.org/viewvc?rev=828784&view=rev >>> Log: >>> Hello world server sample >>> >>> Added: >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/pom.xml >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/ >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/ >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/ >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/ >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/apache/ >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/apache/aries/ >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/apache/aries/blueprint/ >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/apache/aries/blueprint/helloworldserver/ >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/apache/aries/blueprint/helloworldserver/HelloWorldServer.java >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/apache/aries/blueprint/helloworldserver/HelloWorldServerImpl.java >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/resources/ >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/resources/OSGI-INF/ >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/resources/OSGI-INF/blueprint/ >>> >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/resources/OSGI-INF/blueprint/config.xml >>> Modified: >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/ >>> (props changed) >>> >>> Propchange: >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/ >>> >>> ------------------------------------------------------------------------------ >>> --- svn:ignore (added) >>> +++ svn:ignore Thu Oct 22 16:52:12 2009 >>> @@ -0,0 +1,4 @@ >>> +.settings >>> +target >>> +.classpath >>> +.project >>> >>> Added: >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/pom.xml >>> URL: >>> http://svn.apache.org/viewvc/incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/pom.xml?rev=828784&view=auto >>> >>> ============================================================================== >>> --- >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/pom.xml >>> (added) >>> +++ >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/pom.xml >>> Thu Oct 22 16:52:12 2009 >>> @@ -0,0 +1,56 @@ >>> +<!-- >>> + Licensed to the Apache Software Foundation (ASF) under one or more >>> + contributor license agreements. See the NOTICE file distributed >>> with >>> + this work for additional information regarding copyright ownership. >>> + The ASF licenses this file to You under the Apache License, Version >>> 2.0 >>> + (the "License"); you may not use this file except in compliance with >>> + the License. You may obtain a copy of the License at >>> + >>> + http://www.apache.org/licenses/LICENSE-2.0 >>> + >>> + Unless required by applicable law or agreed to in writing, software >>> + distributed under the License is distributed on an "AS IS" BASIS, >>> + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or >>> implied. >>> + See the License for the specific language governing permissions and >>> + limitations under the License. >>> +--> >>> +<project xmlns="http://maven.apache.org/POM/4.0.0"; >>> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; >>> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 >>> http://maven.apache.org/maven-v4_0_0.xsd";> >>> + <modelVersion>4.0.0</modelVersion> >>> + <parent> >>> + <artifactId>blueprint</artifactId> >>> + <groupId>org.apache.aries.blueprint</groupId> >>> + <version>1.0.0-incubating-SNAPSHOT</version> >>> + </parent> >>> + >>> + <artifactId>helloworldserver</artifactId> >>> + <name>Apache Aries Blueprint HelloWorldServer</name> >>> + <packaging>bundle</packaging> >>> + <description>Example blueprint hello world application - >>> server</description> >>> + >>> + <build> >>> + <plugins> >>> + <plugin> >>> + <groupId>org.apache.felix</groupId> >>> + <artifactId>maven-bundle-plugin >>> + </artifactId> >>> + <extensions>true</extensions> >>> + <configuration> >>> + <instructions> >>> + >>> <Bundle-SymbolicName>${pom.groupId}.helloworldserver</Bundle-SymbolicName> >>> + </instructions> >>> + </configuration> >>> + </plugin> >>> + </plugins> >>> + </build> >>> + <dependencies> >>> + <dependency> >>> + <groupId>org.eclipse</groupId> >>> + <artifactId>osgi</artifactId> >>> + <scope>provided</scope> >>> + </dependency> >>> + <dependency> >>> + <groupId>org.apache.aries.blueprint</groupId> >>> + <artifactId>aries-blueprint-api</artifactId> >>> + </dependency> >>> + </dependencies> >>> +</project> >>> >>> Added: >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/apache/aries/blueprint/helloworldserver/HelloWorldServer.java >>> URL: >>> http://svn.apache.org/viewvc/incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/apache/aries/blueprint/helloworldserver/HelloWorldServer.java?rev=828784&view=auto >>> >>> ============================================================================== >>> --- >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/apache/aries/blueprint/helloworldserver/HelloWorldServer.java >>> (added) >>> +++ >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/apache/aries/blueprint/helloworldserver/HelloWorldServer.java >>> Thu Oct 22 16:52:12 2009 >>> @@ -0,0 +1,25 @@ >>> +/** >>> + * Licensed to the Apache Software Foundation (ASF) under one >>> + * or more contributor license agreements. See the NOTICE file >>> + * distributed with this work for additional information >>> + * regarding copyright ownership. The ASF licenses this file >>> + * to you under the Apache License, Version 2.0 (the >>> + * "License"); you may not use this file except in compliance >>> + * with the License. You may obtain a copy of the License at >>> + * >>> + * http://www.apache.org/licenses/LICENSE-2.0 >>> + * >>> + * Unless required by applicable law or agreed to in writing, >>> + * software distributed under the License is distributed on an >>> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>> + * KIND, either express or implied. See the License for the >>> + * specific language governing permissions and limitations >>> + * under the License. >>> + */ >>> +package org.apache.aries.blueprint.helloworldserver; >>> + >>> +public interface HelloWorldServer { >>> + public void hello(); >>> + >>> + public void startUp(); >>> +} >>> \ No newline at end of file >>> >>> Added: >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/apache/aries/blueprint/helloworldserver/HelloWorldServerImpl.java >>> URL: >>> http://svn.apache.org/viewvc/incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/apache/aries/blueprint/helloworldserver/HelloWorldServerImpl.java?rev=828784&view=auto >>> >>> ============================================================================== >>> --- >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/apache/aries/blueprint/helloworldserver/HelloWorldServerImpl.java >>> (added) >>> +++ >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/java/org/apache/aries/blueprint/helloworldserver/HelloWorldServerImpl.java >>> Thu Oct 22 16:52:12 2009 >>> @@ -0,0 +1,30 @@ >>> +/** >>> + * Licensed to the Apache Software Foundation (ASF) under one >>> + * or more contributor license agreements. See the NOTICE file >>> + * distributed with this work for additional information >>> + * regarding copyright ownership. The ASF licenses this file >>> + * to you under the Apache License, Version 2.0 (the >>> + * "License"); you may not use this file except in compliance >>> + * with the License. You may obtain a copy of the License at >>> + * >>> + * http://www.apache.org/licenses/LICENSE-2.0 >>> + * >>> + * Unless required by applicable law or agreed to in writing, >>> + * software distributed under the License is distributed on an >>> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY >>> + * KIND, either express or implied. See the License for the >>> + * specific language governing permissions and limitations >>> + * under the License. >>> + */ >>> +package org.apache.aries.blueprint.helloworldserver; >>> + >>> +public class HelloWorldServerImpl implements HelloWorldServer { >>> + >>> + public void hello() { >>> + System.out.println("======>>> A message from the server: >>> Hello World!"); >>> + } >>> + >>> + public void startUp() { >>> + System.out.println("======>>> Starting HelloWorld >>> Server"); >>> + } >>> +} >>> >>> Added: >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/resources/OSGI-INF/blueprint/config.xml >>> URL: >>> http://svn.apache.org/viewvc/incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/resources/OSGI-INF/blueprint/config.xml?rev=828784&view=auto >>> >>> ============================================================================== >>> --- >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/resources/OSGI-INF/blueprint/config.xml >>> (added) >>> +++ >>> incubator/aries/trunk/blueprint/blueprint-helloworld/helloworldserver/src/main/resources/OSGI-INF/blueprint/config.xml >>> Thu Oct 22 16:52:12 2009 >>> @@ -0,0 +1,30 @@ >>> +<?xml version="1.0" encoding="UTF-8" standalone="no"?> >>> + <!-- >>> + Licensed to the Apache Software Foundation (ASF) under >>> one or more >>> + contributor license agreements. See the NOTICE file >>> distributed with >>> + this work for additional information regarding copyright >>> ownership. >>> + The ASF licenses this file to You under the Apache >>> License, Version >>> + 2.0 (the "License"); you may not use this file except in >>> compliance >>> + with the License. You may obtain a copy of the License at >>> + >>> + http://www.apache.org/licenses/LICENSE-2.0 Unless >>> required by >>> + applicable law or agreed to in writing, software >>> distributed under the >>> + License is distributed on an "AS IS" BASIS, WITHOUT >>> WARRANTIES OR >>> + CONDITIONS OF ANY KIND, either express or implied. See >>> the License for >>> + the specific language governing permissions and >>> limitations under the >>> + License. >>> + --> >>> +<blueprint xmlns="http://www.osgi.org/xmlns/blueprint/v1.0.0"; >>> + >>> + default-availability="optional"> >>> + >>> + >>> + >>> + <bean id="helloserver" >>> class="org.apache.aries.blueprint.helloworldserver.HelloWorldServerImpl" >>> + init-method="startUp"> >>> + </bean> >>> + >>> + <service ref="helloserver" >>> interface="org.apache.aries.blueprint.helloworldserver.HelloWorldServer"/> >>> + >>> +</blueprint> >>> + >>> >>> >>> >>> >> >> > > -- Cheers, Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ ------------------------ Open Source SOA http://fusesource.com
