Fix committed, see ARIES-522 On Wed, Dec 22, 2010 at 15:15, Guillaume Nodet <[email protected]> wrote: > Sure > > On Wed, Dec 22, 2010 at 15:13, Alasdair Nottingham <[email protected]> wrote: >> yeah, you are right it is wrong. I in theory have a test for this, but >> I'm banging my head against pax-exam. Do you want to raise a JIRA and >> put in a fix and I'll commit the test once I beat maven and pax-exam >> into submission? >> >> Alasdair >> >> On 22 December 2010 14:08, Guillaume Nodet <[email protected]> wrote: >>> In the ProxyHandler class, method invoke(), i see: >>> >>> if (proxyManager.isProxy(targetObject)) { >>> args[0] = proxyManager.unwrap(proxy).call(); >>> >>> Shouldn't that be: >>> >>> if (proxyManager.isProxy(targetObject)) { >>> args[0] = proxyManager.unwrap(targetObject).call(); >>> >>> because I think right now, all tests return true because we're >>> comparing the object to itself in all cases. >>> >>> On Wed, Dec 22, 2010 at 14:57, Guillaume Nodet <[email protected]> wrote: >>>> It actually seems to work in some cases. >>>> Or was that fixed recently maybe ? >>>> I need to dig a bit more too, as I do had some broken code a few days ago. >>>> >>>> On Wed, Dec 22, 2010 at 14:26, Alasdair Nottingham <[email protected]> wrote: >>>>> Looking at the code the equals method should work, but there could be >>>>> a bug. I'll try to write a test to check this out. >>>>> >>>>> Alasdair >>>>> >>>>> On 22 December 2010 13:02, Guillaume Nodet <[email protected]> wrote: >>>>>> Isn't there a regression with proxies ? I can't put blueprint proxies >>>>>> in a list and remove them anymore as the equals() method does not work >>>>>> well on those proxies. >>>>>> >>>>>> -- >>>>>> Cheers, >>>>>> Guillaume Nodet >>>>>> ------------------------ >>>>>> Blog: http://gnodet.blogspot.com/ >>>>>> ------------------------ >>>>>> Open Source SOA >>>>>> http://fusesource.com >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Alasdair Nottingham >>>>> [email protected] >>>>> >>>> >>>> >>>> >>>> -- >>>> Cheers, >>>> Guillaume Nodet >>>> ------------------------ >>>> Blog: http://gnodet.blogspot.com/ >>>> ------------------------ >>>> Open Source SOA >>>> http://fusesource.com >>>> >>> >>> >>> >>> -- >>> Cheers, >>> Guillaume Nodet >>> ------------------------ >>> Blog: http://gnodet.blogspot.com/ >>> ------------------------ >>> Open Source SOA >>> http://fusesource.com >>> >> >> >> >> -- >> Alasdair Nottingham >> [email protected] >> > > > > -- > Cheers, > Guillaume Nodet > ------------------------ > Blog: http://gnodet.blogspot.com/ > ------------------------ > Open Source SOA > http://fusesource.com >
-- Cheers, Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ ------------------------ Open Source SOA http://fusesource.com
