> Feedback-ID: i5cf14421:Fastmail
> From: joshua stein <[email protected]>
>
> ---
> sys/dev/fdt/rkiic.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
This diff should not be necessary. The devicetree bindings indicate
that the "rockchip,rk3128-i2c" will also list "rockchip,rk3288-i2c" as
the compatible and we already match on that one.
(This also means that we can remove "rockchip,rk3328-i2c" from the driver)
> diff --git a/sys/dev/fdt/rkiic.c b/sys/dev/fdt/rkiic.c
> index ab07e951aea..b7e3c2d820c 100644
> --- a/sys/dev/fdt/rkiic.c
> +++ b/sys/dev/fdt/rkiic.c
> @@ -110,7 +110,8 @@ rkiic_match(struct device *parent, void *match, void *aux)
> {
> struct fdt_attach_args *faa = aux;
>
> - return (OF_is_compatible(faa->fa_node, "rockchip,rk3288-i2c") ||
> + return (OF_is_compatible(faa->fa_node, "rockchip,rk3128-i2c") ||
> + OF_is_compatible(faa->fa_node, "rockchip,rk3288-i2c") ||
> OF_is_compatible(faa->fa_node, "rockchip,rk3328-i2c") ||
> OF_is_compatible(faa->fa_node, "rockchip,rk3399-i2c"));
> }
> --
> 2.47.1
>
>
