> From: joshua stein <[email protected]>
> Cc: joshua stein <[email protected]>
>
> ---
> sys/dev/mii/miidevs | 1 +
> sys/dev/mii/miidevs.h | 4 +++-
> sys/dev/mii/rlphy.c | 2 ++
> 3 files changed, 6 insertions(+), 1 deletion(-)
Two nits below. ok kettenis@ with those fixed.
> diff --git a/sys/dev/mii/miidevs b/sys/dev/mii/miidevs
> index 2e3b039c712..75ff83e3aab 100644
> --- a/sys/dev/mii/miidevs
> +++ b/sys/dev/mii/miidevs
> @@ -295,6 +295,7 @@ model RDC R6040 0x0003 R6040
> model RDC R6040_2 0x0005 R6040
>
> /* Realtek */
> +model xxREALTEK RTL8201F 0x0001 RTL8201F
> model xxREALTEK RTL8251 0x0000 RTL8251
> model xxREALTEK RTL8211FVD 0x0007 RTL8211F-VD
> model xxREALTEK RTL8201E 0x0008 RTL8201E
We try to sort these in numerical order. So RTL8201F should come
after RTL8251.
> diff --git a/sys/dev/mii/miidevs.h b/sys/dev/mii/miidevs.h
> index 7b4671fb3fb..b6edfe3fab4 100644
> --- a/sys/dev/mii/miidevs.h
> +++ b/sys/dev/mii/miidevs.h
> @@ -1,4 +1,4 @@
> -/* $OpenBSD: miidevs.h,v 1.138 2024/07/27 03:26:12 deraadt Exp $ */
> +/* $OpenBSD$ */
>
> /*
> * THIS FILE AUTOMATICALLY GENERATED. DO NOT EDIT.
> @@ -436,6 +436,8 @@
> #define MII_STR_RDC_R6040_2 "R6040"
>
> /* Realtek */
> +#define MII_MODEL_xxREALTEK_RTL8201F 0x0001
> +#define MII_STR_xxREALTEK_RTL8201F "RTL8201F"
> #define MII_MODEL_xxREALTEK_RTL8251 0x0000
> #define MII_STR_xxREALTEK_RTL8251 "RTL8251"
> #define MII_MODEL_xxREALTEK_RTL8211FVD 0x0007
> diff --git a/sys/dev/mii/rlphy.c b/sys/dev/mii/rlphy.c
> index 4be32035653..ed47601e011 100644
> --- a/sys/dev/mii/rlphy.c
> +++ b/sys/dev/mii/rlphy.c
> @@ -78,6 +78,8 @@ static const struct mii_phydesc rlphys[] = {
> MII_STR_xxREALTEK_RTL8201E },
> { MII_OUI_ICPLUS, MII_MODEL_ICPLUS_IP101,
> MII_STR_ICPLUS_IP101 },
> + { MII_OUI_xxREALTEK, MII_MODEL_xxREALTEK_RTL8201F,
> + MII_STR_xxREALTEK_RTL8201F },
And here it makes more sense if RTL8201F comes immediately after
RTL8201E.
>
> { 0, 0,
> NULL },
> --
> 2.47.1
>
>
