>I don't want to discuss this any further. I'm sorry to be a source of frustration, but you haven't answered my question.
Why? Why is the way it's coded better than what I propose? Previous versions of the code did it "my way." Clearly there was a reason for the change, but I can't think of one. I was able to easily switch the logic, but I don't want to mess with your masterpiece. Everything you do it so well thought out, and who am I to say you're wrong? I'm just trying to understand the reasoning - then I can decide if my specific situation warrants changing this section for each release for use here or what. Thank you for your continued patience. On Thu, May 14, 2015 at 3:14 AM, Thomas Eckardt <thomas.ecka...@thockar.com> wrote: > >Yes , this is the way it works. > > AGAIN: > > If you, as an admin, copy files in to the resend folder (outside the GUI - > or using the file commander) - you have to make sure that the header is > valid for the resend. > Even if you do this using the GUI - take care about what you do. > > I don't want to discuss this any further. > > Thomas > > > > Von: K Post <nntp.p...@gmail.com> > An: ASSP development mailing list <assp-test@lists.sourceforge.net> > Datum: 14.05.2015 04:52 > Betreff: Re: [Assp-test] Bug? Resend Mail using Envelope From > > > > I'm sorry to keep bringing this up, but I'm worried that my changes could > have unforeseen negative consequences. > > >Yes , this is the way it works. > >Thomas > > My way (obviously) seems more logical to me, but why isn't it coded that > way? What am I missing? Is it dangerous reversing the order of analysis > like I did? What's the downside? What's the upside to having it look for > envelope-from first? > > On Sun, May 10, 2015 at 5:57 PM, K Post <nntp.p...@gmail.com> wrote: > > > Can we revisit this? I wound up editing the code, so that the from in > the > > header is used if it's there, with the envelope-from being a backup if > > not. This lets the message appear correctly in the end users' email > > clients without the need of hand editing the message each time something > is > > resent. > > > > Here's the code I'm using: > > # original > > # ($howF, $mailfrom) = ($1,$2) > > # if ($message =~ > > > > /\n(X-ASSP-Envelope-From:)[^\<]*?<?($EmailAdrRe\@$EmailDomainRe)>?\s*\r?\n/sio); > > # ($howF, $mailfrom) = ($1,$2) > > # if (! $mailfrom && $message =~ > > /\n(from:)[^\<]*?<?($EmailAdrRe\@$EmailDomainRe)>?\s*\r?\n/sio); > > > > # modified - use from in the header first, if not there, then use > envelope > > from > > # allows user to see from in the email client as it would have appeared > > with the original message > > ($howF, $mailfrom) = ($1,$2) > > if ($message =~ > > /\n(from:)[^\<]*?<?($EmailAdrRe\@$EmailDomainRe)>?\s*\r?\n/sio); > > ($howF, $mailfrom) = ($1,$2) > > if (! $mailfrom && $message =~ > > > > /\n(X-ASSP-Envelope-From:)[^\<]*?<?($EmailAdrRe\@$EmailDomainRe)>?\s*\r?\n/sio); > > > > > > Is there a downside to doing it this way instead? I see no upside of > > doing it the way it's originally coded, but you know I'm all ears... > > > > On Fri, May 1, 2015 at 10:51 AM, K Post <nntp.p...@gmail.com> wrote: > > > >> Since when, and more importantly why is it a good idea to now have it > >> this way? > >> > >> It didn't used to work this way (going back several years). Don't you > >> think that having the mail come from another sender could cause > confusion - > >> either with people ignoring the resent (by an admin) email, replying to > the > >> wrong address, etc? > >> > >> I'm sure there's a valid reason for this, I'd just like to understand > it. > >> > >> > >> On Fri, May 1, 2015 at 9:31 AM, Thomas Eckardt < > >> thomas.ecka...@thockar.com> wrote: > >> > >>> Yes , this is the way it works. > >>> > >>> Thomas > >>> > >>> > >>> > >>> > >>> > >>> Von: K Post <nntp.p...@gmail.com> > >>> An: ASSP development mailing list > <assp-test@lists.sourceforge.net> > >>> Datum: 01.05.2015 14:46 > >>> Betreff: [Assp-test] Bug? Resend Mail using Envelope From > >>> > >>> > >>> > >>> It appears that copying a message from resend mail has the from line > for > >>> that resent message using the X-ASSP-Envelope-From: line instead of > the > >>> FROM line from the message > >>> > >>> For example, a message sent from > >>> From: "PetCareCompany" <i...@petcarecompany.com> > >>> and X-ASSP-Envelope-From: errors-ouruser=ourdom...@theirsenderco.com > >>> when resent has the FROM line appear as > >>> errors-ouruser=ourdom...@theirsenderco.com > >>> I would have expected the resent message to use the original from > line. > >>> > >>> (I suppose functionality could have changed in newer versions, but my > >>> very > >>> old production version doesn't do this) > >>> > >>> > > ------------------------------------------------------------------------------ > >>> One dashboard for servers and applications across > Physical-Virtual-Cloud > >>> Widest out-of-the-box monitoring support with 50+ applications > >>> Performance metrics, stats and reports that give you Actionable > Insights > >>> Deep dive visibility with transaction tracing using APM Insight. > >>> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > >>> _______________________________________________ > >>> Assp-test mailing list > >>> Assp-test@lists.sourceforge.net > >>> https://lists.sourceforge.net/lists/listinfo/assp-test > >>> > >>> > >>> > >>> > >>> > >>> > >>> DISCLAIMER: > >>> ******************************************************* > >>> This email and any files transmitted with it may be confidential, > legally > >>> privileged and protected in law and are intended solely for the use of > >>> the > >>> > >>> individual to whom it is addressed. > >>> This email was multiple times scanned for viruses. There should be no > >>> known virus in this email! > >>> ******************************************************* > >>> > >>> > >>> > > ------------------------------------------------------------------------------ > >>> One dashboard for servers and applications across > Physical-Virtual-Cloud > >>> Widest out-of-the-box monitoring support with 50+ applications > >>> Performance metrics, stats and reports that give you Actionable > Insights > >>> Deep dive visibility with transaction tracing using APM Insight. > >>> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > >>> _______________________________________________ > >>> Assp-test mailing list > >>> Assp-test@lists.sourceforge.net > >>> https://lists.sourceforge.net/lists/listinfo/assp-test > >>> > >> > >> > > > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications > Performance metrics, stats and reports that give you Actionable Insights > Deep dive visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > _______________________________________________ > Assp-test mailing list > Assp-test@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/assp-test > > > > > > > DISCLAIMER: > ******************************************************* > This email and any files transmitted with it may be confidential, legally > privileged and protected in law and are intended solely for the use of the > > individual to whom it is addressed. > This email was multiple times scanned for viruses. There should be no > known virus in this email! > ******************************************************* > > > ------------------------------------------------------------------------------ > One dashboard for servers and applications across Physical-Virtual-Cloud > Widest out-of-the-box monitoring support with 50+ applications > Performance metrics, stats and reports that give you Actionable Insights > Deep dive visibility with transaction tracing using APM Insight. > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y > _______________________________________________ > Assp-test mailing list > Assp-test@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/assp-test > ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ Assp-test mailing list Assp-test@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/assp-test
