On Tue, Aug 7, 2012 at 6:09 AM, Roland Mainz <roland.ma...@nrubsig.org> wrote: > Hi! > > ---- > > Attached (as "astksh_builtin_poll20120806_001.diff.txt") is the 4th > iteration of the poll(1) patch per review feedback... > > Changes: > - Use of C99 variable length arrays (=VLA) removed... this has been > replaced with the use of a stk object which now keeps track of all > memory allocations > - Custom |strdup()| for sfio has been replaced with |stkcopy()| > - Old, #ifdef'ed out |sfpoll()| code has been purged&&burned > - The code now properly handles large poll arrays without causing > memory corruptions (thanks to Jennifer Pioch for that bug report) > - Use of |errormsg(SH_DICT, ERROR_warn(1), ...);| has been replaced > with |errormsg(SH_DICT, ERROR_error, ...);| > - Debug code has been removed > - Major addition of comments to make the code understandable > > Glenn/David: Do you see anything which still needs to be changed (if > you integrate this and make changes please send diffs back since I > still have to do the mode for non-compound-variable arrays) ?
The patch LGTM. Please have a talk with David whether he'll accept a special version of the patch which has the builtin integrated with #if SHOPT_BLTIN_POLL (default==0) for ksh93u+. Irek _______________________________________________ ast-developers mailing list ast-developers@research.att.com https://mailman.research.att.com/mailman/listinfo/ast-developers
