David, Glenn, Phong, I have extracted some suspicious warnings from my
ast-ksh.20120911 clang compiler build. I think you should look at
these, because they may be serious or stupid bugs:
src/lib/libast/aso/aso.c:856:10: warning: incompatible integer to
pointer conversion passing 'uint64_t' (aka 'unsigned long') to
parameter of type 'void *' [-Wint-conversion]
return _aso_casptr((void**)p, o, n);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
./FEATURE/aso:19:66: note: expanded from macro '_aso_casptr'
#define _aso_casptr(p,o,n)
((void*)__sync_val_compare_and_swap(p,(uint64_t)o,(uint64_t)n))
^
src/lib/libast/aso/aso.c:856:10: warning: incompatible integer to
pointer conversion passing 'uint64_t' (aka 'unsigned long') to
parameter of type 'void *' [-Wint-conversion]
return _aso_casptr((void**)p, o, n);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
./FEATURE/aso:19:78: note: expanded from macro '_aso_casptr'
#define _aso_casptr(p,o,n)
((void*)__sync_val_compare_and_swap(p,(uint64_t)o,(uint64_t)n))
^
2 warnings generated.
src/lib/libast/vmalloc/malloc.c:1397:68: warning: comparison of
unsigned expression >= 0 is always true [-Wtautological-compare]
if (v && vm &&
vm->meth.meth == VM_MTDEBUG && (n = atou(&v)) >= 0)
~~~~~~~~~~~~~~ ^ ~
1 warning generated.
src/cmd/ksh93/bltins/misc.c:425:27: warning: incompatible pointer
types passing 'bool (struct process *, int)' to parameter of type
'int (*)(struct process *, int)' [-Wincompatible-pointer-types]
if(job_walk(shp,sfstdout,job_switch,flag,argv))
^~~~~~~~~~
src/cmd/ksh93/include/jobs.h:191:43: note: passing argument to parameter here
extern int job_walk(Shell_t*,Sfio_t*,int(*)(struct
process*,int),int,char*[]);
^
1 warning generated.
src/cmd/ksh93/bltins/print.c:636:7: warning: comparison of unsigned
expression < 0 is always false [-Wtautological-compare]
if(n < 0)
~ ^ ~
1 warning generated.
src/cmd/ksh93/sh/nvtype.c:936:22: warning: comparison of unsigned
expression < 0 is always false [-Wtautological-compare]
if((n=dp->strsize)<0)
~~~~~~~~~~~~~~~^~
1 warning generated.
src/cmd/ksh93/sh/io.c:1827:15: warning: if statement has empty body
[-Wempty-body]
if(!savestr);
^
src/cmd/ksh93/sh/io.c:1827:15: note: put the semicolon on a separate
line to silence this warning [-Wempty-body]
1 warning generated.
sh/path.c:178:10: warning: comparison of unsigned expression < 0 is
always false [-Wtautological-compare]
if(left<0 && (avlast-av)<2)
~~~~^~
1 warning generated.
Olga
--
, _ _ ,
{ \/`o;====- Olga Kryzhanovska -====;o`\/ }
.----'-/`-/ olga.kryzhanov...@gmail.com \-`\-'----.
`'-..-| / http://twitter.com/fleyta \ |-..-'`
/\/\ Solaris/BSD//C/C++ programmer /\/\
`--` `--`
_______________________________________________
ast-developers mailing list
ast-developers@research.att.com
https://mailman.research.att.com/mailman/listinfo/ast-developers
