> On Nov. 21, 2013, 12:53 p.m., opticron wrote: > > branches/12/include/asterisk/stasis_app.h, line 180 > > <https://reviewboard.asterisk.org/r/2947/diff/5/?file=48327#file48327line180> > > > > This should return the enum instead of int. > > Kevin Harwell wrote: > The problem with making this an enum is currently it is assumed different > enum types could be returned. So instead of having a single master enum for > all result types, resources could define and use their expected result types > specific to their modules.
If this could return multiple different enum types, collisions between values in the enums could produce incorrect error messages. As an example, a rule from module B could cause a bridge entry attempted by module A to fail. The enum that currently exists is global and not module-specific even though the only error value it contains is from a single module. - opticron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2947/#review10246 ----------------------------------------------------------- On Nov. 21, 2013, 1:50 p.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/2947/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2013, 1:50 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-22624 > https://issues.asterisk.org/jira/browse/ASTERISK-22624 > > > Repository: Asterisk > > > Description > ------- > > Added a channel recording flag that is checked before adding a channel to a > bridge. If the the channel is currently being recorded a "409 Conflict" is > returned and the channel is not added to the bridge. > > > Diffs > ----- > > branches/12/rest-api/api-docs/bridges.json 402969 > branches/12/res/stasis/control.c 402969 > branches/12/res/stasis/command.c 402969 > branches/12/res/stasis/command.h 402969 > branches/12/res/res_stasis_recording.c 402969 > branches/12/res/res_stasis_playback.c 402969 > branches/12/res/res_stasis_answer.c 402969 > branches/12/res/res_ari_bridges.c 402969 > branches/12/res/ari/resource_bridges.c 402969 > branches/12/include/asterisk/stasis_app_impl.h 402969 > branches/12/include/asterisk/stasis_app.h 402969 > > Diff: https://reviewboard.asterisk.org/r/2947/diff/ > > > Testing > ------- > > Ran a manual test and also wrote a testsuite test: > https://reviewboard.asterisk.org/r/2951/ > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev