> On Nov. 21, 2013, 2:17 p.m., Joshua Colp wrote: > > The code itself looks fine, the only nagging question I have is why not > > just treat the variable as a temporary return variable in the case when you > > have multiple MixMonitor instances and use Set in the dialplan to set > > another variable to the value. *shrug*
Two reasons: 1) MixMonitor's invocation is not limited to the dialplan. It has the potential to be started by AMI as well. Therefore, if you had an oddball situation where both a dialplan invocation and an AMI invocation occurred simultaneously, there's a race condition where they each will think that MIXMONITOR_FILENAME is "their" filename. 2) There is precedent in MixMonitor for such an option. The 'i' option allows for you to specify a channel variable into which the MixMonitor's unique ID will be set. Having a similar option for a filename fits the mold pretty well also. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3023/#review10231 ----------------------------------------------------------- On Nov. 20, 2013, 9:12 p.m., Mark Michelson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3023/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2013, 9:12 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > This change introduces an 'f' option for the MixMonitor() application. The > argument for this option specifies a channel variable into which the > application should store the filename (as in, the full path) instead of the > standard MIXMONITOR_FILENAME. > > The rationale for this option is that MixMonitor is structured in such a way > that a single channel may have multiple simultaneous MixMonitors running at > any given time. Thus, the MixMonitor application should not have any > assumptions that the channel has only a single MixMonitor being run on it. > Setting a single MIXMONITOR_FILENAME channel variable violates such > assumptions by overwriting the value set from previous invocations of > MixMonitor. By using the 'f' and 'i' options for MixMonitor, a user can > easily manage multiple recordings on a single channel. > > > Diffs > ----- > > /trunk/apps/app_mixmonitor.c 402883 > > Diff: https://reviewboard.asterisk.org/r/3023/diff/ > > > Testing > ------- > > See https://reviewboard.asterisk.org/r/3024/ > > > Thanks, > > Mark Michelson > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
