----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2944/#review10303 -----------------------------------------------------------
branches/12/configs/pjsip.conf.sample <https://reviewboard.asterisk.org/r/2944/#comment19688> I'd extend this explanation a bit more. "Endpoint to use when sending an outbound request to a URI without a specified endpoint." branches/12/res/res_pjsip.c <https://reviewboard.asterisk.org/r/2944/#comment19682> Stray ; at the end of the default value. branches/12/res/res_pjsip_messaging.c <https://reviewboard.asterisk.org/r/2944/#comment19683> sips should still be valid here, otherwise you can't get the PJSIP transport manager to use a TLS transport branches/12/res/res_pjsip_messaging.c <https://reviewboard.asterisk.org/r/2944/#comment19684> I don't like this. Falling back to the default outbound endpoint if the specified one could not be found could bring about unexpected behavior for the user, and be harder to diagnose. I would prefer that it would be an error situation. branches/12/res/res_pjsip_messaging.c <https://reviewboard.asterisk.org/r/2944/#comment19685> As this now properly decs the reference count on the contact you are not guaranteed that contact->uri will remain valid past this. branches/12/res/res_pjsip_messaging.c <https://reviewboard.asterisk.org/r/2944/#comment19686> Same applies here since it is scoped, unless I'm crazy. branches/12/res/res_pjsip_messaging.c <https://reviewboard.asterisk.org/r/2944/#comment19687> You could make this error a bit more ... warm. ;) - Joshua Colp On Dec. 3, 2013, 8:12 p.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/2944/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2013, 8:12 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > Added the ability to send messages to a URI (an associated endpoint is no > longer needed). > > > Diffs > ----- > > branches/12/res/res_pjsip_messaging.c 403341 > branches/12/res/res_pjsip/pjsip_configuration.c 403341 > branches/12/res/res_pjsip/include/res_pjsip_private.h 403341 > branches/12/res/res_pjsip/config_global.c 403341 > branches/12/res/res_pjsip.c 403341 > branches/12/include/asterisk/res_pjsip.h 403341 > branches/12/configs/pjsip.conf.sample 403341 > > Diff: https://reviewboard.asterisk.org/r/2944/diff/ > > > Testing > ------- > > Had the PJSIP message module send a SIP message to a specified IP address. > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev