----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3035/#review10375 -----------------------------------------------------------
Ship it! /branches/12/funcs/func_pjsip_endpoint.c <https://reviewboard.asterisk.org/r/3035/#comment19771> Just curious, but why does "disallow" get this special treatment? - Mark Michelson On Dec. 10, 2013, 2:34 a.m., Matt Jordan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3035/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2013, 2:34 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > The impetus for this function came from looking at the CHANNEL function for > chan_sip, and starting to map out what properties should be applied to > chan_pjsip. > > While I was looking at it, I thought that - other than the name of the > endpoint associated with the channel - endpoint details really shouldn't come > from the CHANNEL function. They should come from something else. Hence, the > PJSIP_ENDPOINT function. > > This function lets you query any property configured on an endpoint, for any > endpoint, from the dialplan. Assuming the CHANNEL function gets applied to > chan_pjsip, this would let you extract information about a channel's endpoint > - or whatever endpoint they're going to go talk to. > > This has some obvious implications in knowing what's about to happen before > you go Dial some endpoint. > > As an aside, I think this patch also shows (to a small extent) the usefulness > of both Sorcery as well as XML configuration information. More lines of code > are spent on sanitizing input than anything else. > > > Diffs > ----- > > /branches/12/main/sorcery.c 403491 > /branches/12/funcs/func_pjsip_endpoint.c PRE-CREATION > /branches/12/doc/snapshots.xslt 403491 > /branches/12/doc/appdocsxml.xslt PRE-CREATION > /branches/12/doc/appdocsxml.dtd 403491 > /branches/12/Makefile 403491 > > Diff: https://reviewboard.asterisk.org/r/3035/diff/ > > > Testing > ------- > > Testsuite test written and available here: > > https://reviewboard.asterisk.org/r/3034/ > > > Thanks, > > Matt Jordan > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
