-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3068/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-22962
    https://issues.asterisk.org/jira/browse/ASTERISK-22962


Repository: Asterisk


Description
-------

When creating channels via ARI, the current code fails to provide any default 
format capabilities. For non-virtual channels this isn't really a problem - the 
channels typically receive their capabilities as a result of the underlying 
channel driver configuration. For virtual channels (such as Local channels), 
the lack of any format capabilities causes the Asterisk core to make some 'odd' 
choices with respect to the translation paths. The issue reporter had some 
paths that had 3 hops on each channel leg, causing multiple transcodings and 
some really crappy audio/performance.

By specifying a baseline of SLIN, we prevent that from occurring. Note that 
this is what AMI does when it performs an Originate, as does res_clioriginate.

Note that this does not solve the odd translation paths that were created or 
some other more deep performance issues in the translation/format capability 
core. Those should be addressed separately of this problem.


Diffs
-----

  /branches/12/res/ari/resource_channels.c 403703 

Diff: https://reviewboard.asterisk.org/r/3068/diff/


Testing
-------

Without this patch: bad audio, bad performance.
With this patch: acceptable performance/audio.


Thanks,

Matt Jordan

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to