-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3043/
-----------------------------------------------------------
(Updated Dec. 19, 2013, 8:04 p.m.)
Review request for Asterisk Developers.
Changes
-------
Implemented the formatter registration pattern.
Each module or sub-module registers a container getter, a header formatter, and
a body formatter.
Each implementer is responsible for knowing what children it needs to invoke
and in what order.
A few new files were created... pjsip_cli.c, res_pjsip_cli.h
Although functional, there is still refactoring I need to do and I'm sure there
are leaks I haven't found. I'll keep working on it.
Bugs: ASTERISK-22610
https://issues.asterisk.org/jira/browse/ASTERISK-22610
Repository: Asterisk
Description
-------
Implements the following cli commands:
pjsip list aors
pjsip list auths
pjsip list channels
pjsip list contacts
pjsip list endpoints
pjsip show aor(s)
pjsip show auth(s)
pjsip show channels
pjsip show endpoint(s)
Also...
Minor modifications made to the AMI command implementations to facilitate reuse.
New function ast_variable_list_sort added to config.c and config.h to implement
variable list sorting.
New api ast_sip_for_each_identify added to module
res_pjsip_endpoint_identifier_ip. Required new files
res_pjsip_endpoint_identifier_ip.h and
res_pjsip_endpoint_identifier_ip.exports.in.
Implementation of the summary statistics is still pending.
I'm sure there will be lots of feedback here. :)
Diffs (updated)
-----
branches/12/res/res_pjsip_registrar.c 404396
branches/12/res/res_pjsip_endpoint_identifier_ip.c 404396
branches/12/res/res_pjsip/pjsip_configuration.c 404396
branches/12/res/res_pjsip/pjsip_cli.c PRE-CREATION
branches/12/res/res_pjsip/location.c 404396
branches/12/res/res_pjsip/include/res_pjsip_private.h 404396
branches/12/res/res_pjsip/config_auth.c 404396
branches/12/main/sorcery.c 404396
branches/12/main/config.c 404396
branches/12/include/asterisk/sorcery.h 404396
branches/12/include/asterisk/res_pjsip_cli.h PRE-CREATION
branches/12/include/asterisk/res_pjsip.h 404396
branches/12/include/asterisk/config.h 404396
Diff: https://reviewboard.asterisk.org/r/3043/diff/
Testing (updated)
-------
I've gone through all the combinations of actions and objects and made sure at
least the correct objects are returned, there are no segfaults, errors, etc.
I *think* the formatting is correct but I'll need some feedback.
Thanks,
George Joseph
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
