-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3109/
-----------------------------------------------------------

Review request for Asterisk Developers.


Bugs: ASTERISK-22946
    https://issues.asterisk.org/jira/browse/ASTERISK-22946


Repository: Asterisk


Description
-------

In ASTERISK-12117 an improvement to retain the same local from tag resulted in 
an undesirable behavior when registrations expire quickly (i.e. every 30 
seconds).  The transmit_register() function creates a new dialog (sip_pvt) for 
every register attempt.  However, with the local tag no longer changing, a 
previous register dialog could still be matched if it had not timed out and 
been removed prior to the next register attempt.  When the old register dialog 
was found, it had the wrong sequence number and would cause repeated 
retransmits on timeout.  Rather than a significant rework of 
transmit_register(), this patch eliminates the problem by destroying the old 
dialog immediately after the 200 OK is received indicating a successful 
registration.


Diffs
-----

  /branches/1.8/channels/chan_sip.c 405032 

Diff: https://reviewboard.asterisk.org/r/3109/diff/


Testing
-------


Thanks,

Scott Griepentrog

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to