> On Jan. 16, 2014, 8:10 a.m., Joshua Colp wrote: > > branches/12/res/res_pjsip/config_auth.c, line 292 > > <https://reviewboard.asterisk.org/r/3104/diff/1/?file=51192#file51192line292> > > > > You don't need to store the sorcery instance, you can use > > ast_sip_get_sorcery to retrieve it. Same goes for the other places you've > > used this approach.
Yeah, I was thinking that sorcery was wasn't shared across modules then remembered that most of the cli stuff is in the same module. > On Jan. 16, 2014, 8:10 a.m., Joshua Colp wrote: > > branches/12/res/res_pjsip/config_transport.c, lines 282-283 > > <https://reviewboard.asterisk.org/r/3104/diff/1/?file=51193#file51193line282> > > > > Just curious why the change... easier to read? As I was trying to figure out why ipv6 wasn't working I was tinkering here. It is a little easier to read now. - George ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3104/#review10595 ----------------------------------------------------------- On Jan. 6, 2014, 2:49 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3104/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2014, 2:49 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > Adds identify, transport and registration support to the CLI. > Creates 3 additional callbacks, one for an iterator, one for a comparator and > one for a container. This eliminates the link dependency from higher level > modules to lower level ones. > Eliminates duplicate sorting. > Cleans up output formatting. > Pushes cli registration down to the implementing source file. > Adds several ast_sip_destroy_sorcery functions to complement existing > ast_sip_sorcery_initialize functions. The destroy functions unregister cli > commands and cli formatters. > > > Diffs > ----- > > branches/12/res/res_pjsip_outbound_registration.c 405000 > branches/12/res/res_pjsip_endpoint_identifier_ip.c 405000 > branches/12/res/res_pjsip/pjsip_configuration.c 405000 > branches/12/res/res_pjsip/pjsip_cli.c 405000 > branches/12/res/res_pjsip/location.c 405000 > branches/12/res/res_pjsip/config_transport.c 405000 > branches/12/res/res_pjsip/config_auth.c 405000 > branches/12/include/asterisk/res_pjsip_cli.h 405000 > branches/12/include/asterisk/res_pjsip.h 405000 > > Diff: https://reviewboard.asterisk.org/r/3104/diff/ > > > Testing > ------- > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
