----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3132/#review10644 -----------------------------------------------------------
/asterisk/trunk/tests/channels/pjsip/allow_all_sdp/test-config.yaml <https://reviewboard.asterisk.org/r/3132/#comment20133> If you knock down the number of tests, I'd remove this. It'd be a bit excessive. /asterisk/trunk/tests/channels/pjsip/allow_all_sdp/test-config.yaml <https://reviewboard.asterisk.org/r/3132/#comment20135> I'd prefer not to have all of these tests. 1. Most of what these tests cover - early media, deferred SDP, various transports - is already covered. What we need to test here is that configuring and endpoint with "allow=all" results in the correct outbound offer - the rest of this behaviour is already tested. 2. This test already has lots of problems running under Bamboo. It fails probably 25% of the time. We shouldn't have put this many SIPp scenarios under a single test; I'm guessing that this test will suffer from the same problem. /asterisk/trunk/tests/channels/pjsip/tests.yaml <https://reviewboard.asterisk.org/r/3132/#comment20134> Thinking for the future: This is really a test for Offer/Answer - if we configure an endpoint with all, do we offer the correct thing? I'd put this into something like the following: sdp_offer_answer/nominal/outbound/offer_all We will, at some point, have off nominal offers sent to Asterisk, and have Asterisk deal with offers that contain all (or a lot) of formats. With Josh's format work, this is coming up sooner rather than later. - Matt Jordan On Jan. 16, 2014, 4:13 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3132/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2014, 4:13 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23018 > https://issues.asterisk.org/jira/browse/ASTERISK-23018 > > > Repository: testsuite > > > Description > ------- > > This is just a copy of > tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_host with > allow=all instead of allow=ulaw. > > > Diffs > ----- > > /asterisk/trunk/tests/channels/pjsip/tests.yaml 4563 > /asterisk/trunk/tests/channels/pjsip/allow_all_sdp/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/allow_all_sdp/sipp/playback_with_initial_sdp.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/allow_all_sdp/sipp/playback_with_deferred_sdp.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/allow_all_sdp/sipp/echo_with_initial_sdp.xml > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/allow_all_sdp/sipp/echo_with_deferred_sdp.xml > PRE-CREATION > /asterisk/trunk/tests/channels/pjsip/allow_all_sdp/configs/ast1/pjsip.conf > PRE-CREATION > > /asterisk/trunk/tests/channels/pjsip/allow_all_sdp/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/3132/diff/ > > > Testing > ------- > > It correctly fails without the 3131 code implemented. > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
