----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3167/#review10720 -----------------------------------------------------------
I can't really comment about bast practices. I imagine Russell and Paul will have advice on what is right or wrong about what you've done. I just spotted a typo, though :) branches/12/UPGRADE.txt <https://reviewboard.asterisk.org/r/3167/#comment20215> s/pj_systems/ps_systems/ - Mark Michelson On Jan. 30, 2014, 5:51 p.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3167/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 5:51 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > A couple of the scripts had errors that would not allow a full migration to > take place. The extensions table needed to make its 'id' column a primary > key in order to work with mysql. The other script ...add_endpoints... was > missing tables that it was trying to add columns to. > > Added the primary key on id for extensions and added the tables in for the > missing pjsip configuration options. > > > Diffs > ----- > > > branches/12/contrib/ast-db-manage/config/versions/581a4264e537_adding_extensions.py > 406846 > > branches/12/contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py > 406846 > branches/12/UPGRADE.txt 406846 > > Diff: https://reviewboard.asterisk.org/r/3167/diff/ > > > Testing > ------- > > Ran the alembic scripts against postgres and mysql database servers to make > sure everything was created correctly. > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
