----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3168/#review10725 -----------------------------------------------------------
branches/12/res/res_pjsip_nat.c <https://reviewboard.asterisk.org/r/3168/#comment20219> I would actually go so far as to do a URI comparison here... cause if this happens multiple times you are going to keep growing the dialog pool usage. - Joshua Colp On Jan. 30, 2014, 8:27 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3168/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2014, 8:27 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23106 > https://issues.asterisk.org/jira/browse/ASTERISK-23106 > > > Repository: Asterisk > > > Description > ------- > > In NAT scenarios where a call is placed to a Grandstream phone, res_pjsip > will sometimes send the ACK to a 200 OK to the private address of the device > behind the NAT instead of the address of the NAT device. This corrects that > behavior by rewriting the address in the Contact header in the incoming 200 > OK and the dialog's target address if necessary (since it has already been > rewritten to the incorrect private address). > > > Diffs > ----- > > branches/12/res/res_pjsip_nat.c 406916 > > Diff: https://reviewboard.asterisk.org/r/3168/diff/ > > > Testing > ------- > > Manual testing and a new testsuite test at > https://reviewboard.asterisk.org/r/3169/ > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
