----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3199/#review10843 -----------------------------------------------------------
Ship it! Just a minor nit. /trunk/main/sched.c <https://reviewboard.asterisk.org/r/3199/#comment20434> Stray blank line got added. - rmudgett On Feb. 8, 2014, 5:54 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3199/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2014, 5:54 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > The scheduler currently stores scheduled items in two ways: a hashtab and a > heap. The heap is used for actually scheduling while the hashtab is used for > fast retrieval under certain circumstances. In practice having the hashtab > comes at a cost under normal use. Each time something is scheduled two memory > allocations occur: one for the scheduled item itself and one for the hashtab. > Each time something is rescheduled the hashtab entry is freed and allocated > yet again. If you have a scheduled item which is rescheduled over and over > this can be substantial. > > This change removes the hashtab usage and uses the heap for finding things. > > > Diffs > ----- > > /trunk/main/sched.c 407748 > > Diff: https://reviewboard.asterisk.org/r/3199/diff/ > > > Testing > ------- > > Ran scheduler unit test and also forced the scheduler to get used for > Playback. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
