> On Jan. 1, 2014, 1:41 a.m., Matt Jordan wrote: > > /trunk/contrib/asterisk.service, lines 11-14 > > <https://reviewboard.asterisk.org/r/3062/diff/2/?file=49947#file49947line11> > > > > Similarly to the ExecStopPost, it'd be nice - if not necessary - to > > have a pre-start script that checks the file descriptor/core file limits > > and set them to the system max/unlimited.
Checking them seems like a poor choice. Asterisk should just use what it have. The unit file should require resources, if necessary. > On Jan. 1, 2014, 1:41 a.m., Matt Jordan wrote: > > /trunk/contrib/asterisk.service, line 18 > > <https://reviewboard.asterisk.org/r/3062/diff/2/?file=49947#file49947line18> > > > > I think this patch should consider providing a basic stop post script > > that does what safe_asterisk performs with respect to core files at the > > very least. One of the most widely used and useful features is > > safe_asterisk's management of core files in the event of an Asterisk crash; > > it'd be nice to have that here as well. Added a script, but did not install it. I took the actions safe_asterisk does. I'm not really happy with the result (though it is usable as an example). - Tzafrir ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3062/#review10499 ----------------------------------------------------------- On Dec. 24, 2013, 4:49 p.m., Tzafrir Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3062/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2013, 4:49 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > Installs a systemd service file for Asterisk. > > Systeemd is the new "one daemon to rule them all" for Linux: > http://www.freedesktop.org/wiki/Software/systemd/ > On systems without systemd this should be just a harmless (though maybe > annoying) text file. > > This is aimed at replacing safe_asterisk with a more reliable main loop. It > almost does that. Is still fails to handle failures, as it seems that > systemd's ExecPostStop command does not get the exist status of the stopped > command. > > > Diffs > ----- > > /trunk/contrib/asterisk.service PRE-CREATION > /trunk/Makefile 404563 > > Diff: https://reviewboard.asterisk.org/r/3062/diff/ > > > Testing > ------- > > > Thanks, > > Tzafrir Cohen > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
