----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3228/ -----------------------------------------------------------
Review request for Asterisk Developers and Matt Jordan. Repository: Asterisk Description ------- Apparently I broke the build with r408084 ( https://reviewboard.asterisk.org/r/3212/ ). Reproducing: $ touch .cleancount $ make make[1]: Entering directory `.../asterisk-11.x' make[2]: Entering directory `.../asterisk-11.x' make[3]: Entering directory `.../asterisk-11.x' ... <infinite loop here> $ touch .lastclean $ make CC="cc" CXX="" LD="" AR="" RANLIB="" CFLAGS="" LDFLAGS="" make -C menuselect CONFIGURE_SILENT="--silent" makeopts make[1]: Entering directory `.../asterisk-11.x/menuselect' make[1]: `makeopts' is up to date. ... <successful build here> There is no problem on 1.8, because it lacks these dependencies on .lastclean: menuselect/menuselect: menuselect/makeopts .lastclean +$(MAKE_MENUSELECT) menuselect ... menuselect/makeopts: makeopts .lastclean +$(MAKE_MENUSELECT) makeopts Obviously the build should be unbroken. Three options: (A) I have a super simple patch here that abuses grep to look for the MENUSELECT_EMBED= variable here. If you have no grep binary in path, it gracefully falls back to the previous behaviour. (B) We could simply revert. (C) Someone could try to untangle the .lastclean dependencies. But that should probably be after option (B). (And for options A and B, should they be from 1.8 and up or 11 and up?) Diffs ----- /branches/11/Makefile 408192 Diff: https://reviewboard.asterisk.org/r/3228/diff/ Testing ------- Thanks, wdoekes
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
