----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3235/#review10897 -----------------------------------------------------------
Ship it! /branches/1.8/main/config.c <https://reviewboard.asterisk.org/r/3235/#comment20515> IMHO, the constants (digits) look nicer on the RHS of the comparison. - wdoekes On Feb. 17, 2014, 9:57 p.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3235/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2014, 9:57 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: AST-1303 > https://issues.asterisk.org/jira/browse/AST-1303 > > > Repository: Asterisk > > > Description > ------- > > Repeatedly modifying config files and reloading too fast sometimes fails to > reload the configuration because the cached modification timestamp has one > second resolution. > > * Added file size and nanosecond resolution fields to the cached config file > modification timestamp information. Now if the file size changes or the file > system supports nanosecond resolution the modified file has a better chance > of being detecting for reload. > > * Added a missing unlock in an off-nominal code path. > > > Diffs > ----- > > /branches/1.8/main/config.c 408290 > > Diff: https://reviewboard.asterisk.org/r/3235/diff/ > > > Testing > ------- > > Added a debug statement to the cfmstat_cmp() and checked that the saved > stat() information changed when expected. > Did several reloads of app_queue which indicates if it is not reloading > queuerules.conf if the file did not change. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
